fix(influxdbexporter): handle empty attribute values #21526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
May 6, 2023
|
@jacobmarble there is another linter error, PTAL |
dmitryax
approved these changes
May 8, 2023
jacobmarble
added a commit
to jacobmarble/opentelemetry-collector-contrib
that referenced
this pull request
Aug 30, 2023
Closes open-telemetry#22850 InfluxDB does not allow empty tag values in line protocol. This change adds a second test to confirm that the InfluxDB exporter does not emit empty tag values. See open-telemetry#21526 for the original fix to handling empty attribute values. This PR exists because I forgot I had fixed open-telemetry#21474, then tried to fix open-telemetry#22850 and now realize that open-telemetry#22850 and open-telemetry#21474 are dupes. Live and learn.
codeboten
pushed a commit
that referenced
this pull request
Sep 15, 2023
**Description:** <Describe what has changed.>
InfluxDB does not allow empty tag values in line protocol. This change
adds a second test to confirm that the InfluxDB exporter does not emit
empty tag values.
See #21526 for the original fix to handling empty attribute values. This
PR exists because I forgot I had fixed #21474, then tried to fix #22850
and now realize that #22850 and #21474 are dupes. Live and learn.
**Link to tracking Issue:**
Closes #22850
**Testing:**
**Documentation:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since otelcol-contrib v0.75.0, the hostmetrics receiver is emitting metrics with empty string attribute values, such as
device = string(""). I've confirmed that this behavior started in v0.75.0.I'm not certain that empty attribute values are disallowed in the otel spec, but this error is emitted by the InfluxDB line protocol encoder, which has rejected empty tag values for at least three years.
Nevertheless, the InfluxDB exporter can do better by quietly dropping these attributes (which is semantically equivalent in InfluxDB).
Link to tracking Issue:
Closes #21474
Testing:
Unit tested the changed method.
Documentation: n/a