Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] [cmd/mdatagen] Remove redundant function NewMetricsBuilderConfig #21518

Merged
merged 1 commit into from
May 6, 2023
Merged

[chore] [cmd/mdatagen] Remove redundant function NewMetricsBuilderConfig #21518

merged 1 commit into from
May 6, 2023

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented May 6, 2023

The function should not be used, so no need to generate it

@dmitryax dmitryax changed the title [cmd/mdatagen] Remove redundant function NewMetricsBuilderConfig [chore] [cmd/mdatagen] Remove redundant function NewMetricsBuilderConfig May 6, 2023
@dmitryax dmitryax force-pushed the remove-redundant-NewMetricsBuilderConfig branch from 4b81001 to 931d121 Compare May 6, 2023 01:03
@dmitryax dmitryax merged commit 6672679 into open-telemetry:main May 6, 2023
@github-actions github-actions bot added this to the next release milestone May 6, 2023
@dmitryax dmitryax deleted the remove-redundant-NewMetricsBuilderConfig branch May 6, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@antonblock antonblock Awaiting requested review from antonblock

@armstrmi armstrmi Awaiting requested review from armstrmi

@BinaryFissionGames BinaryFissionGames Awaiting requested review from BinaryFissionGames

@cpheps cpheps Awaiting requested review from cpheps

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

@dehaansa dehaansa Awaiting requested review from dehaansa

@jamesmoessis jamesmoessis Awaiting requested review from jamesmoessis

@JonathanWamsley JonathanWamsley Awaiting requested review from JonathanWamsley

@Mrod1598 Mrod1598 Awaiting requested review from Mrod1598

@nslaughter nslaughter Awaiting requested review from nslaughter

@rmfitzpatrick rmfitzpatrick Awaiting requested review from rmfitzpatrick

@schmikei schmikei Awaiting requested review from schmikei

@shalper2 shalper2 Awaiting requested review from shalper2

@StefanKurek StefanKurek Awaiting requested review from StefanKurek

Assignees

@TylerHelmuth TylerHelmuth

Labels
cmd/mdatagen mdatagen command receiver/activedirectoryds receiver/aerospike receiver/apache receiver/bigip receiver/chrony receiver/couchdb receiver/dockerstats receiver/elasticsearch receiver/expvar receiver/filestats receiver/flinkmetrics receiver/haproxy receiver/hostmetrics receiver/httpcheck HTTP Check receiver receiver/iis receiver/kafkametrics receiver/kubeletstats receiver/memcached receiver/mongodb receiver/mongodbatlas receiver/mysql receiver/nginx receiver/nsxt NSXT Receiver receiver/oracledb receiver/postgresql receiver/rabbitmq receiver/redis Redis related issues receiver/riak receiver/saphana receiver/snowflake Snowflake receiver receiver/sqlserver receiver/sshcheck receiver/vcenter receiver/zookeeper
Projects
None yet
Milestone
v0.77.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitryax @atoulme @TylerHelmuth