Make lint/fmt for each folder just to be sure

receiver/sapmreceiver/factory.go

@@ -54,9 +54,9 @@ func (f *Factory) CustomUnmarshaler() component.CustomUnmarshaler {
 func (f *Factory) CreateDefaultConfig() configmodels.Receiver {
  return &Config{
  ReceiverSettings: configmodels.ReceiverSettings{
-  TypeVal: typeStr,
-  NameVal: typeStr,
-  Endpoint: defaultEndpoint,
+ TypeVal: typeStr,
+ NameVal: typeStr,
+ Endpoint: defaultEndpoint,
  },
  }
 }

receiver/sapmreceiver/trace_receiver_test.go

@@ -186,9 +186,9 @@ func sendSapm(endpoint string, sapm *splunksapm.PostSpansRequest, zipped bool, t
  client := &http.Client{}
 
  if tlsEnabled {
- caCert, err := ioutil.ReadFile("./testdata/testcert.crt")
- if err != nil {
- return nil, fmt.Errorf("failed to load certificate: %s", err.Error())
+ caCert, errCert := ioutil.ReadFile("./testdata/testcert.crt")
+ if errCert != nil {
+ return nil, fmt.Errorf("failed to load certificate: %s", errCert.Error())
  }
  caCertPool := x509.NewCertPool()
  caCertPool.AppendCertsFromPEM(caCert)

receiver/signalfxreceiver/config.go

@@ -14,12 +14,11 @@
 
 package signalfxreceiver
 
-import(
+import (
  "go.opentelemetry.io/collector/config/configmodels"
  "go.opentelemetry.io/collector/config/configtls"
 )
 
-
 // Config defines configuration for the SignalFx receiver.
 type Config struct {
  configmodels.ReceiverSettings `mapstructure:",squash"` // squash ensures fields are correctly decoded in embedded struct

receiver/signalfxreceiver/config_test.go

@@ -22,7 +22,7 @@ import (
  "github.com/stretchr/testify/require"
  "go.opentelemetry.io/collector/config"
  "go.opentelemetry.io/collector/config/configmodels"
- "go.opentelemetry.io/collector/config/configtls"
+ "go.opentelemetry.io/collector/config/configtls"
 )
 
 func TestLoadConfig(t *testing.T) {

receiver/signalfxreceiver/receiver.go

@@ -134,7 +134,7 @@ func (r *sfxReceiver) Start(_ context.Context, host component.Host) error {
  if r.config.TLSCredentials != nil {
  host.ReportFatalError(r.server.ListenAndServeTLS(r.config.TLSCredentials.CertFile, r.config.TLSCredentials.KeyFile))
  } else {
- if err := r.server.ListenAndServe(); err != nil && err != http.ErrServerClosed {
+ if err = r.server.ListenAndServe(); err != nil && err != http.ErrServerClosed {
  host.ReportFatalError(err)
  }
  }

receiver/signalfxreceiver/receiver_test.go

@@ -391,6 +391,7 @@ func Test_sfxReceiver_TLS(t *testing.T) {
  url := fmt.Sprintf("https://%s/v2/datapoint", addr)
 
  req, err := http.NewRequest("POST", url, bytes.NewReader(body))
+ require.NoError(t, err, fmt.Sprintf("should have no errors with new request: %v", err))
  req.Header.Set("Content-Type", "application/x-protobuf")
 
  caCert, err := ioutil.ReadFile("./testdata/testcert.crt")

testbed/tests/receivers.go

@@ -45,7 +45,7 @@ func NewSapmDataReceiver(port int) *SapmDataReceiver {
 func (sr *SapmDataReceiver) Start(tc *testbed.MockTraceConsumer, mc *testbed.MockMetricConsumer) error {
  sapmCfg := sapmreceiver.Config{
  ReceiverSettings: configmodels.ReceiverSettings{
-  Endpoint: fmt.Sprintf("localhost:%d", sr.Port),
+ Endpoint: fmt.Sprintf("localhost:%d", sr.Port),
  },
  }
  var err error
@@ -100,7 +100,7 @@ func NewSFxMetricsDataReceiver(port int) *SFxMetricsDataReceiver {
 func (sr *SFxMetricsDataReceiver) Start(tc *testbed.MockTraceConsumer, mc *testbed.MockMetricConsumer) error {
  addr := fmt.Sprintf("localhost:%d", sr.Port)
  config := signalfxreceiver.Config{
-  ReceiverSettings: configmodels.ReceiverSettings{Endpoint: addr},
+ ReceiverSettings: configmodels.ReceiverSettings{Endpoint: addr},
  }
  var err error
  sr.receiver, err = signalfxreceiver.New(zap.L(), config, mc)