[servicegraphprocessor/servicegraphconnector] Change metric names to match the spec #21098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
reviewed
May 23, 2023
|
|
||
| mCount := ms.At(0) | ||
| verifyCount(t, mCount) | ||
|
|
||
| mDuration := ms.At(1) |
There was a problem hiding this comment.
Should this be kept for a couple of releases to allow people to upgrade to the new metric name? Which one would best represent the old one? Can you also add more info in the changelog telling folks what they should do not to have their dashboards broken?
There was a problem hiding this comment.
Added the legacy metric names under a feature flag and improved the description. Thanks for the review.
jpkrohling
approved these changes
Jun 7, 2023
|
Sorry for taking so long to review this. It looks like there's a conflict now. Are you able to fix it? Ping me once you do, so that I can review it again. Thanks! |
|
No worries! Rebased and ready for merge @jpkrohling |
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…match the spec (open-telemetry#21098) * Change metrics to match Tempo spec * Update tests * Add chlog entry * Fix duration * Poke CI * Add legacy metrics under flag * Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes servicegraph metrics to match the spec
Link to tracking Issue:
Solves #18743 and #16578
Testing:
Added tests to make sure that the metrics match the spec
Documentation: