Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/datadog] Use generated headers #21055

Merged
merged 2 commits into from
May 4, 2023

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Apr 18, 2023

Description:
Updates the datadogprocessor to use generated header. Reviewing the processor I did not see any Warnings that need called out. @mx-psi @gbbr @dineshg13 if there are any appropriate Warnings to list let me know and I'll update the PR.

Link to tracking Issue:
#19172

@TylerHelmuth TylerHelmuth requested review from a team and mx-psi as code owners April 18, 2023 20:56
@TylerHelmuth TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 18, 2023
@github-actions github-actions bot requested review from dineshg13 and gbbr April 18, 2023 20:56
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbbr is this component stateful in any way?

@TylerHelmuth
Copy link
Member Author

Pinging @mx-psi @gbbr @dineshg13

@mx-psi
Copy link
Member

mx-psi commented May 4, 2023

@gbbr see my question above :)

@gbbr
Copy link
Member

gbbr commented May 4, 2023

Hi @TylerHelmuth, thanks for the PR! In the sense described here, this component is not stateful.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a rebase to fix the lint job

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label May 4, 2023
@TylerHelmuth TylerHelmuth merged commit dda09dc into open-telemetry:main May 4, 2023
@TylerHelmuth TylerHelmuth deleted the ddp-generated-header branch May 4, 2023 20:40
@github-actions github-actions bot added this to the next release milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/datadog ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants