Added Loki exporter codeowner #1928
Conversation
Signed-off-by: Granville Schmidt <[email protected]>
|
@anuraaga @bogdandrutu - Per comment on PR 1900 ( #1900 (comment) ) |
Signed-off-by: Granville Schmidt <[email protected]>
| @@ -28,6 +28,7 @@ exporter/jaegerthrifthttpexporter/ @open-telemetry/collector-contrib-app | |||
| exporter/kinesisexporter/ @open-telemetry/collector-contrib-approvers @owais | |||
| exporter/loadbalancingexporter/ @open-telemetry/collector-contrib-approvers @jpkrohling | |||
| exporter/logzioexporter/ @open-telemetry/collector-contrib-approvers @yyyogev | |||
| exporter/lokiexporter/ @open-telemetry/collector-contrib-approvers @gramidt | |||
There was a problem hiding this comment.
Would be good to have 2 people so if you create a PR the other person reviews initially the PR.
There was a problem hiding this comment.
Absolutely! I'll ask around who would like to join me as the owner for this exporter. If you have anyone in mind, let me know.
Thank you again for all of your help!
Codecov Report
@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
+ Coverage 90.18% 90.19% +0.01%
==========================================
Files 385 385
Lines 19056 19056
==========================================
+ Hits 17185 17187 +2
+ Misses 1399 1398 -1
+ Partials 472 471 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This adds the initial config and factory boilerplate and corresponding tests. Contributes to: open-telemetry/opentelemetry-collector#882 Testing: config and factory tests unit tests added. Documentation: Added README. The next PR will add the exporting logic.
Signed-off-by: Granville Schmidt [email protected]
Description:
Adding myself as the code owner of the Loki exporter ( #1900 )
Link to tracking Issue:
#1894
Testing:
N/A
Documentation:
N/A