Switch SAPM receiver to internal data model #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
|
@tigrannajaryan please take a look |
tigrannajaryan
approved these changes
Apr 24, 2020
|
Performance degraded because we introduced OTLP translation additionally to OC. Once exporter is migrated it should be improved. Test results: Before: After: |
@dmitryax makes sense. Let's see where we land after migrating the exporter. It will be useful to compare "before" results from this PR to "after" results when exporter is also migrated. |
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
* Implement factory and config for sampling processor (head-based) * Change Config name
dmitryax
deleted the
feature/dmitryax/switch-sapm-receiver-to-internal
branch
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
* Fix defaultoutput * Implement PR feedback
straussb
added a commit
to straussb/opentelemetry-collector-contrib
that referenced
this pull request
Mar 29, 2024
…ightreceiver. (open-telemetry#186) * Add Elastic Fabric Adapter (EFA) metric collection to awscontainerinsightreceiver. The new component scrapes hardware counters from /sys/class/infiniband on disk. The layout of that directory is: /sys/class/infiniband/<device name> └── ports └── 1 └── hw_counters ├── rdma_read_bytes ├── rdma_write_bytes ├── rdma_write_recv_bytes ├── rx_bytes ├── rx_drops └── tx_bytes These are cumulative counters and so they are converted to deltas before sending down the pipeline. We sum up data from all ports. The device data is joined with data from the kubelet podresources API which tells us which container a given device is assigned to. The metrics are reported at container, pod, and node levels. This commit also refactors some metric decoration code from cadvisor to a common localnode decorator, intended to be used by any awscontainerinsightreceiver component that gathers metrics from the local node (as oppoosed to e.g. the k8s control plane scraper). This is because we want to share the logic of populating PodName, Kubernetes labels, etc. I also renamed RawContainerInsightsMetric to CIMetricImpl for brevity.
straussb
added a commit
to straussb/opentelemetry-collector-contrib
that referenced
this pull request
Mar 29, 2024
…ainerinsightreceiver. (open-telemetry#186)" This reverts commit eed8454. Unit tests are failing in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.