Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StatsD receiver]Revise readme for StatsD receiver to add use cases and TODOs #1856

Merged

Conversation

gavindoudou
Copy link
Contributor

Description:
Revise README.md to add use cases and TODOs. Addressed some left comments in the merged PR.

Link to tracking Issue: #1670

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #1856 (dcc8d4c) into master (914479f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1856      +/-   ##
==========================================
- Coverage   89.90%   89.88%   -0.02%     
==========================================
  Files         380      380              
  Lines       18335    18335              
==========================================
- Hits        16484    16481       -3     
- Misses       1384     1387       +3     
  Partials      467      467              
Flag Coverage Δ
integration 69.82% <ø> (-0.07%) ⬇️
unit 88.59% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/prometheusexecreceiver/receiver.go 85.83% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914479f...dcc8d4c. Read the comment docs.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 24, 2020
@bogdandrutu bogdandrutu merged commit 8105983 into open-telemetry:master Dec 24, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
This enables usage of SpanID data type. Now span id is hex encoded
as it is required by OTLP specification.

Contributes to: open-telemetry/opentelemetry-collector#1177
@gavindoudou gavindoudou deleted the statsDWithAggregation branch March 18, 2021 22:51
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
#1856)

* Honor context Done in SSP Shutdown

* Update PR number in changelog

* Update comment

* Add tests

* Make tests more concise

* Restructure tests for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants