Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spanmetrics] Move spanmetrics cfg validation to ConfigValidator#Validate. #18530

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

kovrus
Copy link
Member

@kovrus kovrus commented Feb 13, 2023

Description:

Components:

  • spanmetrics processor
  • spanmetrics connector

Move spanmetrics components configuration validations to ConfigValidator#Validate.

@runforesight
Copy link

runforesight bot commented Feb 13, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(3 seconds) has decreased 42 minutes 3 seconds compared to main branch avg(42 minutes 6 seconds).
View More Details

✅  check-links workflow has finished in 44 seconds (1 minute 44 seconds less than main branch avg.) and finished at 23rd Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 8 seconds (1 minute 56 seconds less than main branch avg.) and finished at 23rd Feb, 2023.


Job Failed Steps Tests
publish-latest -     🔗  N/A See Details
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 52 seconds (5 minutes 25 seconds less than main branch avg.) and finished at 23rd Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 39 minutes 2 seconds (29 minutes 34 seconds less than main branch avg.) and finished at 23rd Feb, 2023.


Job Failed Steps Tests
unittest-matrix (1.20, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, extension) -     🔗  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, processor) -     🔗  ✅ 1510  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1510  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2577  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-0) -     🔗  ✅ 2577  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, exporter) -     🔗  ✅ 2457  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2457  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1932  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-1) -     🔗  ✅ 1932  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, other) -     🔗  ✅ 4771  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4771  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
checks -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 18 minutes 38 seconds and finished at 23rd Feb, 2023.


Job Failed Steps Tests
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 11 minutes 29 seconds (4 minutes 25 seconds less than main branch avg.) and finished at 23rd Feb, 2023.


Job Failed Steps Tests
kubernetes-test (v1.25.3) -     🔗  N/A See Details

⭕  changelog workflow has finished in 3 seconds (2 minutes 43 seconds less than main branch avg.) and finished at 23rd Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 3 seconds (42 minutes 3 seconds less than main branch avg.) and finished at 23rd Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@github-actions github-actions bot added the processor/spanmetrics Span Metrics processor label Feb 13, 2023
@kovrus kovrus marked this pull request as ready for review February 13, 2023 14:19
@kovrus kovrus requested a review from a team as a code owner February 13, 2023 14:19
@kovrus kovrus requested a review from dashpole February 13, 2023 14:19
@kovrus
Copy link
Member Author

kovrus commented Feb 13, 2023

cc: @albertteoh

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple of nits.

processor/spanmetricsprocessor/config.go Outdated Show resolved Hide resolved
processor/spanmetricsprocessor/config.go Show resolved Hide resolved
@kovrus kovrus force-pushed the spanmetrics-move-cfg-validation branch from 607bcda to 90fb7d8 Compare February 14, 2023 11:36
@kovrus kovrus force-pushed the spanmetrics-move-cfg-validation branch from 90fb7d8 to b8b6ca1 Compare February 14, 2023 12:48
@kovrus
Copy link
Member Author

kovrus commented Feb 17, 2023

cc: @Cluas

@kovrus kovrus force-pushed the spanmetrics-move-cfg-validation branch 3 times, most recently from 876b6eb to ad5aeec Compare February 20, 2023 14:23
@kovrus kovrus requested review from djaglowski and removed request for albertteoh February 20, 2023 15:01
@kovrus kovrus force-pushed the spanmetrics-move-cfg-validation branch 2 times, most recently from 99d1ebc to b1ecf60 Compare February 21, 2023 17:58
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes seem reasonable, from what I can see it is just moving validation to be with the respective files more closely.

processor/spanmetricsprocessor/config.go Outdated Show resolved Hide resolved
@kovrus kovrus force-pushed the spanmetrics-move-cfg-validation branch from d67107e to 13b50da Compare February 23, 2023 08:37
@kovrus kovrus added the ready to merge Code review completed; ready to merge by maintainers label Feb 23, 2023
@kovrus kovrus changed the title [chore] Move spanmetrics cfg validation to ConfigValidator#Validate. [connectors/spanmetrics] Move spanmetrics cfg validation to ConfigValidator#Validate. Feb 24, 2023
@kovrus kovrus changed the title [connectors/spanmetrics] Move spanmetrics cfg validation to ConfigValidator#Validate. [spanmetrics] Move spanmetrics cfg validation to ConfigValidator#Validate. Feb 24, 2023
@codeboten codeboten merged commit 99c3d98 into open-telemetry:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/spanmetrics processor/spanmetrics Span Metrics processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants