Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/promtail] remove promtail receiver completely #18524

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

mar4uk
Copy link
Contributor

@mar4uk mar4uk commented Feb 13, 2023

Description:
Promtail receiver in its current implementation has a dependency on Loki that leads to a huge amount of
dependencies. It is getting difficult to maintain those dependencies. That's why the decision to
remove promtail receiver was made

Link to tracking Issue: 18474, 18493

@runforesight
Copy link

runforesight bot commented Feb 13, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(5 seconds) has decreased 40 minutes 45 seconds compared to main branch avg(40 minutes 50 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (40 minutes 45 seconds less than main branch avg.) and finished at 14th Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 15 seconds (1 minute 51 seconds less than main branch avg.) and finished at 14th Feb, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 36 seconds (1 minute less than main branch avg.) and finished at 14th Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 3 minutes 27 seconds and finished at 14th Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  load-tests workflow has finished in 22 minutes 52 seconds (⚠️ 5 minutes 58 seconds more than main branch avg.) and finished at 14th Feb, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 16 minutes 54 seconds (⚠️ 8 minutes 6 seconds more than main branch avg.) and finished at 14th Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  e2e-tests workflow has finished in 16 minutes 28 seconds and finished at 14th Feb, 2023.


Job Failed Steps Tests
kubernetes-test -     🔗  N/A See Details

 build-and-test workflow has finished in 10 minutes 30 seconds (54 minutes 59 seconds less than main branch avg.) and finished at 14th Feb, 2023.


Job Failed Steps Tests
unittest-matrix (1.19, extension) N/A  ✅ 537  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2574  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) N/A  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1509  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 1509  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2455  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2574  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2455  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) N/A  ✅ 1928  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1928  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4684  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4684  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@@ -0,0 +1,19 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: 'deprecation'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what change_type this PR lies to... deprecation fits the most probably, but I can change it

@mar4uk
Copy link
Contributor Author

mar4uk commented Feb 14, 2023

Did the rebase. Some checks failed, but it doesn't look related to my changes🤔

# honnef.co/go/tools/staticcheck
Error: /home/runner/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4032:29: righti.Method(i).Origin undefined (type *types.Func has no field or method Origin)
Error: /home/runner/go/pkg/mod/honnef.co/go/[email protected]/staticcheck/lint.go:4037:36: sel.Obj().(*types.Func).Origin undefined (type *types.Func has no field or method Origin)
note: module requires Go 1.19
# honnef.co/go/tools/unused
Error: /home/runner/go/pkg/mod/honnef.co/go/[email protected]/unused/unused.go:419:[14](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4172171381/jobs/7223052467#step:7:15): obj.Origin undefined (type *types.Var has no field or method Origin)
Error: /home/runner/go/pkg/mod/honnef.co/go/[email protected]/unused/unused.go:421:14: obj.Origin undefined (type *types.Func has no field or method Origin)
note: module requires Go 1.19
make: *** [Makefile.Common:44: /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/golangci-lint] Error 2
Error: Process completed with exit code 2.

@mx-psi
Copy link
Member

mx-psi commented Feb 14, 2023

Seems to have passed now 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants