[exporter/datadog] Run API key validation in separate goroutine #18239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foresight Summary
View More Details build-and-test workflow has finished in 46 minutes 42 seconds (6 minutes 37 seconds less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| integration-tests | N/A | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
mx-psi
approved these changes
Feb 2, 2023
Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Why? Can you add more details? |
|
This issue originates from this PR: #13732 (comment). Running the API validation synchronously significantly contributes to the exporter start time (serverless environments are especially sensitive to it), and the response is not used unless config.fail_on_invalid_key is specified. |
|
This is now ready to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Run API key validation on Datadog exporter in separate goroutine
More context: see #13732 and #18238
Link to tracking Issue:
Fixes #18238