-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/pdatatest] Do not ignore timestamps in CompareMetrics, use options #17983
Merged
bogdandrutu
merged 1 commit into
open-telemetry:main
from
dmitryax:pmetric-test-dont-ignore-timestamps
Jan 24, 2023
Merged
[pkg/pdatatest] Do not ignore timestamps in CompareMetrics, use options #17983
bogdandrutu
merged 1 commit into
open-telemetry:main
from
dmitryax:pmetric-test-dont-ignore-timestamps
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
a team,
djaglowski,
dashpole,
codeboten and
MovieStoreGuy
as code owners
January 24, 2023 04:03
github-actions
bot
added
pkg/pdatatest
receiver/aerospike
receiver/apache
receiver/bigip
receiver/couchdb
receiver/dockerstats
receiver/elasticsearch
receiver/expvar
receiver/flinkmetrics
receiver/httpcheck
HTTP Check receiver
receiver/memcached
receiver/mongodb
receiver/mysql
receiver/nginx
receiver/nsxt
NSXT Receiver
receiver/postgresql
receiver/rabbitmq
receiver/riak
receiver/saphana
receiver/snmp
receiver/snowflake
Snowflake receiver
receiver/vcenter
receiver/zookeeper
labels
Jan 24, 2023
Foresight Summary
View More Details✅ telemetrygen workflow has finished in 4 minutes 37 seconds (
|
Job | Failed Steps | Tests | |
---|---|---|---|
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
build-dev | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 4 minutes 49 seconds (⚠️ 2 minutes 21 seconds more than main
branch avg.) and finished at 24th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ changelog workflow has finished in 5 minutes 22 seconds (⚠️ 3 minutes 17 seconds more than main
branch avg.) and finished at 24th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 6 minutes 53 seconds and finished at 24th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
✅ check-links workflow has finished in 8 minutes 34 seconds (⚠️ 6 minutes 42 seconds more than main
branch avg.) and finished at 24th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
build-and-test workflow has finished in 16 minutes 58 seconds (34 minutes 37 seconds less than main
branch avg.) and finished at 24th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
unittest-matrix (1.18, internal) | N/A | ✅ 561 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, internal) | N/A | ✅ 561 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-traces | N/A | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-metrics | N/A | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, processor) | N/A | ✅ 1470 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, extension) | N/A | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, extension) | N/A | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, processor) | N/A | ✅ 1470 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-0) | N/A | ✅ 2568 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-0) | N/A | ✅ 2568 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, exporter) | N/A | ✅ 2498 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, exporter) | N/A | ✅ 2498 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | N/A | ✅ 4630 ❌ 0 ⏭ 0 🔗 | See Details |
integration-tests | N/A | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, other) | N/A | ✅ 4630 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | N/A | ✅ 1895 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-1) | N/A | ✅ 1895 ❌ 0 ⏭ 0 🔗 | See Details |
✅ load-tests workflow has finished in 16 minutes 58 seconds (⚠️ 2 minutes 38 seconds more than main
branch avg.) and finished at 24th Jan, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
❌ build-and-test-windows workflow has finished in 18 minutes 58 seconds (21 minutes 46 seconds less than main
branch avg.) and finished at 24th Jan, 2023. 1 job failed. There are 3 test failures.
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix (internal) | - 🔗 | ✅ 525 ❌ 0 ⏭ 0 🔗 | See Details |
windows-unittest-matrix (extension) | - 🔗 | ✅ 515 ❌ 0 ⏭ 0 🔗 | See Details |
windows-unittest-matrix (receiver-0) | Run Unit tests 🔗 | ✅ 82 ❌ 3 ⏭ 0 🔗 | See Details |
windows-unittest-matrix (other) | - 🔗 | ✅ 81 ❌ 0 ⏭ 0 🔗 | See Details |
windows-unittest-matrix (exporter) | - 🔗 | ✅ 692 ❌ 0 ⏭ 0 🔗 | See Details |
windows-unittest-matrix (receiver-1) | - 🔗 | ✅ 377 ❌ 0 ⏭ 0 🔗 | See Details |
windows-unittest-matrix (processor) | - 🔗 | ✅ 431 ❌ 0 ⏭ 0 🔗 | See Details |
windows-unittest | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
dmitryax
force-pushed
the
pmetric-test-dont-ignore-timestamps
branch
7 times, most recently
from
January 24, 2023 07:38
f780be6
to
de7941d
Compare
TylerHelmuth
approved these changes
Jan 24, 2023
djaglowski
approved these changes
Jan 24, 2023
dmitryax
force-pushed
the
pmetric-test-dont-ignore-timestamps
branch
3 times, most recently
from
January 24, 2023 17:27
0154cf6
to
0feee66
Compare
Windows tests are blocked by #17999 |
It's pretty common to ignore timestamps when using CompareMetrics in tests for scrapers, but it's not obvious behavior for other use cases. We should provide options to explicitly ignore timestamps. That will make the Compare... functions provide clean comparison with not implicit behavior.
dmitryax
force-pushed
the
pmetric-test-dont-ignore-timestamps
branch
from
January 24, 2023 19:28
0feee66
to
4878248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg/pdatatest
receiver/aerospike
receiver/apache
receiver/bigip
receiver/couchdb
receiver/dockerstats
receiver/elasticsearch
receiver/expvar
receiver/flinkmetrics
receiver/httpcheck
HTTP Check receiver
receiver/memcached
receiver/mongodb
receiver/mysql
receiver/nginx
receiver/nsxt
NSXT Receiver
receiver/postgresql
receiver/rabbitmq
receiver/riak
receiver/saphana
receiver/snmp
receiver/snowflake
Snowflake receiver
receiver/vcenter
receiver/zookeeper
Run Windows
Enable running windows test on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty common to ignore timestamps when using CompareMetrics in tests for scrapers, but it's not apparent behavior for other use cases. We should provide options to ignore timestamps explicitly. That will make the
Compare...
functions provide a clean comparison with no implicit behavior.Updates #17865