Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] adopt GCI to manage imports #17585

Merged
merged 5 commits into from
Jan 19, 2023
Merged

[chore] adopt GCI to manage imports #17585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a52635
[chore] adopt GCI to manage imports
atoulme Jan 15, 2023
ae5ea2b
fix top comment being removed
atoulme Jan 17, 2023
3519012
remove impi make target, remove gogci and gci make targets, and add g…
atoulme Jan 18, 2023
66a806c
remove impi
atoulme Jan 18, 2023
4cd47db
adopt golangci-lint
atoulme Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove impi make target, remove gogci and gci make targets, and add g… 
…ci to linters of golangci-lint
  • Loading branch information
@atoulme
atoulme committed Jan 19, 2023
commit 3519012cac4200f43951a98cb069b18e6405748f
6 changes: 0 additions & 6 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,6 @@ jobs:
run: |
make -j2 generate
git diff --exit-code ':!*go.sum' || (echo 'Generated code is out of date, please run "make generate" and commit the changes in this PR.' && exit 1)
- name: Impi
run: make -j2 goimpi
- name: GCI
run: |
make -j2 gogci
git diff --exit-code || (echo 'Imports are not formatted properly, please run "make gogci" and commit the changes in this PR' && exit 1)
- name: MultimodVerify
run: make multimod-verify
- name: Components dropdown in issue templates
Expand Down
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ linters:
- errcheck
- errorlint
- exportloopref
- gci
- gocritic
- gofmt
- goimports
Expand Down
8 changes: 0 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,6 @@ gofmt:
golint:
$(MAKE) $(FOR_GROUP_TARGET) TARGET="lint"

.PHONY: goimpi
goimpi: $(IMPI)
@$(MAKE) $(FOR_GROUP_TARGET) TARGET="impi"

.PHONY: gogci
gogci: install-tools
@$(MAKE) $(FOR_GROUP_TARGET) TARGET="gci"

.PHONY: goporto
goporto: $(PORTO)
$(PORTO) -w --include-internal --skip-dirs "^cmd$$" ./
Expand Down