[chore] partial revert of 7711ef492bbd60dab9cf5858a39e2fb2e3054b8d #17578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the main code of 7711ef4 to unblock windows tests. Will need more investigation to get the right fix in. See open-telemetry#17576 pinging @MovieStoreGuy as the original author of the change. Signed-off-by: Alex Boten <[email protected]>
Foresight Summary
View More Details⭕ changelog workflow has finished in 4 seconds (2 minutes less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changelog | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 5 seconds (44 minutes 50 seconds less than main branch avg.) and finished at 13th Jan, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| windows-unittest-matrix | - 🔗 | N/A | See Details |
| windows-unittest | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 41 seconds (1 minute 18 seconds less than main branch avg.) and finished at 13th Jan, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changed files | - 🔗 | N/A | See Details |
| check-links | - 🔗 | N/A | See Details |
✅ telemetrygen workflow has finished in 56 seconds (1 minute 34 seconds less than main branch avg.) and finished at 13th Jan, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| build-dev | - 🔗 | N/A | See Details |
| publish-latest | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 59 seconds (1 minute 32 seconds less than main branch avg.) and finished at 13th Jan, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| build-dev | - 🔗 | N/A | See Details |
| publish-latest | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 16 seconds (4 minutes 36 seconds less than main branch avg.) and finished at 13th Jan, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
✅ load-tests workflow has finished in 8 minutes (6 minutes 59 seconds less than main branch avg.) and finished at 13th Jan, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
| setup-environment | - 🔗 | N/A | See Details |
✅ build-and-test workflow has finished in 8 minutes 13 seconds (40 minutes 37 seconds less than main branch avg.) and finished at 13th Jan, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| checks | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
dmitryax
reviewed
Jan 13, 2023
| @@ -99,7 +104,7 @@ func generateFile(tmplFile string, outputFile string, md metadata) error { | |||
| }, | |||
| "stringsJoin": strings.Join, | |||
| "inc": func(i int) int { return i + 1 }, | |||
| }).ParseFS(templateFS, tmplFile)) | |||
There was a problem hiding this comment.
If templateFS is not being used anymore, I think it should be a full revert.
There was a problem hiding this comment.
I figured it would be coming back, which is why i left it and the tests here.
dmitryax
approved these changes
Jan 13, 2023
MovieStoreGuy
added a commit
to atlassian-forks/opentelemetry-collector-contrib
that referenced
this pull request
Jan 16, 2023
This reverts commit 534df82.
dmitryax
pushed a commit
that referenced
this pull request
Jan 17, 2023
mms2409
pushed a commit
to draios/opentelemetry-collector-contrib
that referenced
this pull request
Jan 19, 2023
This reverts the main code of 7711ef4 to unblock windows tests. Will need more investigation to get the right fix in. See open-telemetry#17576 pinging @MovieStoreGuy as the original author of the change. Signed-off-by: Alex Boten <[email protected]>
mms2409
pushed a commit
to draios/opentelemetry-collector-contrib
that referenced
this pull request
Jan 19, 2023
* Revert "[chore] partial revert of 7711ef4 (open-telemetry#17578)"
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the main code of 7711ef4 to unblock windows tests. Will need more investigation to get the right fix in.
See #17576
pinging @MovieStoreGuy as the original author of the change.
Signed-off-by: Alex Boten [email protected]