Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [receiver/solacereceiver] Fix failing windows tests #17202

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

mcardy
Copy link
Contributor

@mcardy mcardy commented Dec 22, 2022

Description: Increases delay on certain tests to allow enough time to pass on windows. Apparently 2ms/5ms is too aggressive for the windows scheduling, so less granularity is required.

Link to tracking Issue: Fixes #17197

Testing: N/A

Documentation: N/A

@runforesight
Copy link

runforesight bot commented Dec 22, 2022

Foresight Summary

    
Major Impacts

TestRabbitmqIntegration ❌ failed 1 times in 3 runs (33% fail rate).
TestRabbitmqIntegration/Running_rabbitmq_3.9 ❌ failed 1 times in 3 runs (33% fail rate).
build-and-test-windows duration(22 minutes 7 seconds) has decreased 21 minutes 11 seconds compared to main branch avg(43 minutes 18 seconds).
View More Details

⭕  changelog workflow has finished in 6 seconds (8 minutes 56 seconds less than main branch avg.) and finished at 22nd Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  check-links workflow has finished in 52 seconds (2 minutes 32 seconds less than main branch avg.) and finished at 22nd Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 14 seconds (2 minutes 32 seconds less than main branch avg.) and finished at 22nd Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 16 seconds (6 minutes 33 seconds less than main branch avg.) and finished at 22nd Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 8 minutes 9 seconds (9 minutes 2 seconds less than main branch avg.) and finished at 22nd Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  build-and-test-windows workflow has finished in 22 minutes 7 seconds (21 minutes 11 seconds less than main branch avg.) and finished at 22nd Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix (processor) -     🔗  ✅ 1474  ❌ 0  ⏭ 0    🔗 See Details
windows-unittest-matrix (extension) -     🔗  ✅ 515  ❌ 0  ⏭ 0    🔗 See Details
windows-unittest-matrix (other) -     🔗  ✅ 4260  ❌ 0  ⏭ 0    🔗 See Details
windows-unittest-matrix (exporter) -     🔗  ✅ 2410  ❌ 0  ⏭ 0    🔗 See Details
windows-unittest-matrix (receiver-1) -     🔗  ✅ 1822  ❌ 0  ⏭ 0    🔗 See Details
windows-unittest-matrix (receiver-0) -     🔗  ✅ 2532  ❌ 0  ⏭ 0    🔗 See Details
windows-unittest-matrix (internal) -     🔗  ✅ 556  ❌ 0  ⏭ 0    🔗 See Details
windows-unittest -     🔗  N/A See Details

✅  build-and-test workflow has finished in 36 minutes 39 seconds (22 minutes 38 seconds less than main branch avg.) and finished at 22nd Dec, 2022.


Job Failed Steps Tests
unittest-matrix (1.18, exporter) N/A  ✅ 2447  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax dmitryax added the Run Windows Enable running windows test on a PR label Dec 22, 2022
@dmitryax
Copy link
Member

@mcardy, thanks for fixing it. Can you please rebase to make sure that the tests are green?

@dmitryax dmitryax merged commit c5504a6 into open-telemetry:main Dec 22, 2022
@mcardy mcardy deleted the windows_test_fix branch December 22, 2022 18:27
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/solace Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/solace] Tests failing on Windows
3 participants