-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Deprecate Processor related structs and functions #17032
Merged
bogdandrutu
merged 2 commits into
open-telemetry:main
from
codeboten:codeboten/make-updateotel-fdef8b181a06a90bd6da5e7ce59d94ecf2939027
Dec 15, 2022
Merged
[chore] Deprecate Processor related structs and functions #17032
bogdandrutu
merged 2 commits into
open-telemetry:main
from
codeboten:codeboten/make-updateotel-fdef8b181a06a90bd6da5e7ce59d94ecf2939027
Dec 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first in a series of commit to bring core dependency up to main component.MakeProcessorFactoryMap -> processor.MakeFactoryMap component.ProcessorFactory -> processor.Factory componenttest.NewNopProcessorCreateSettings -> processortest.NewNopCreateSettings component.TracesProcessor -> processor.Traces component.MetricsProcessor -> processor.Metrics component.LogsProcessor -> processor.Logs component.NewProcessorFactory -> processor.NewFactory Signed-off-by: Alex Boten <[email protected]>
codeboten
requested review from
djaglowski,
dashpole,
jmacd,
dmitryax,
jpkrohling,
Aneurysm9,
MovieStoreGuy,
mx-psi,
TylerHelmuth,
bogdandrutu,
evan-bradley,
jsuereth,
punya and
arminru
as code owners
December 14, 2022 23:40
github-actions
bot
added
cmd/configschema
configschema command
cmd/mdatagen
mdatagen command
cmd/otelcontribcol
otelcontribcol command
cmd/oteltestbedcol
confmap/provider/s3provider
exporter/alibabacloudlogservice
Alibaba components
exporter/awscloudwatchlogs
awscloudwatchlogs exporter
exporter/awsemf
awsemf exporter
exporter/awskinesis
exporter/awsxray
exporter/azuremonitor
labels
Dec 14, 2022
github-actions
bot
added
exporter/jaeger
exporter/jaegerthrifthttp
exporter/kafka
exporter/loadbalancing
exporter/logicmonitor
exporter/logzio
exporter/loki
Loki Exporter
exporter/mezmo
exporter/opencensus
exporter/parquet
exporter/prometheus
exporter/prometheusremotewrite
exporter/pulsar
exporter/sapm
exporter/sentry
exporter/signalfx
exporter/skywalking
exporter/splunkhec
exporter/sumologic
exporter/tanzuobservability
exporter/tencentcloudlogservice
exporter/zipkin
extension/asapauth
labels
Dec 14, 2022
Foresight Summary
View More Details⭕ changelog workflow has finished in 3 seconds (7 minutes 23 seconds less than
|
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 3 seconds (40 minutes 42 seconds less than main
branch avg.) and finished at 14th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 39 seconds (2 minutes 40 seconds less than main
branch avg.) and finished at 14th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 53 seconds (2 minutes 47 seconds less than main
branch avg.) and finished at 14th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 10 minutes 31 seconds and finished at 15th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
✅ build-and-test workflow has finished in 45 minutes 50 seconds (14 minutes 30 seconds less than main
branch avg.) and finished at 15th Dec, 2022. There are 6 test failures.
Job | Failed Steps | Tests | |
---|---|---|---|
correctness-metrics | - 🔗 | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, internal) | - 🔗 | ✅ 592 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, internal) | - 🔗 | ✅ 592 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-traces | - 🔗 | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, extension) | - 🔗 | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, processor) | - 🔗 | ✅ 1441 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, extension) | - 🔗 | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, processor) | - 🔗 | ✅ 1441 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-0) | - 🔗 | ✅ 2534 ❌ 1 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-0) | - 🔗 | ✅ 2534 ❌ 1 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, other) | - 🔗 | ✅ 4363 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, exporter) | - 🔗 | ✅ 2237 ❌ 2 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-1) | - 🔗 | ✅ 1854 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | - 🔗 | ✅ 4363 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, exporter) | - 🔗 | ✅ 2237 ❌ 2 ⏭ 0 🔗 | See Details |
integration-tests | - 🔗 | ✅ 53 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | - 🔗 | ✅ 1854 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
check-collector-module-version | - 🔗 | N/A | See Details |
check-codeowners | - 🔗 | N/A | See Details |
checks | - 🔗 | N/A | See Details |
lint-matrix (receiver-0) | - 🔗 | N/A | See Details |
lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
lint-matrix (processor) | - 🔗 | N/A | See Details |
lint-matrix (extension) | - 🔗 | N/A | See Details |
lint-matrix (exporter) | - 🔗 | N/A | See Details |
lint-matrix (internal) | - 🔗 | N/A | See Details |
lint-matrix (other) | - 🔗 | N/A | See Details |
build-examples | - 🔗 | N/A | See Details |
unittest (1.19) | - 🔗 | N/A | See Details |
unittest (1.18) | - 🔗 | N/A | See Details |
lint | - 🔗 | N/A | See Details |
cross-compile (darwin, amd64) | - 🔗 | N/A | See Details |
cross-compile (darwin, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, 386) | - 🔗 | N/A | See Details |
cross-compile (linux, amd64) | - 🔗 | N/A | See Details |
cross-compile (linux, arm) | - 🔗 | N/A | See Details |
cross-compile (linux, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, ppc64le) | - 🔗 | N/A | See Details |
cross-compile (windows, 386) | - 🔗 | N/A | See Details |
cross-compile (windows, amd64) | - 🔗 | N/A | See Details |
build-package (deb) | - 🔗 | N/A | See Details |
build-package (rpm) | - 🔗 | N/A | See Details |
windows-msi | - 🔗 | N/A | See Details |
publish-check | - 🔗 | N/A | See Details |
publish-dev | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 19 minutes 15 seconds (⚠️ 2 minutes 20 seconds more than main
branch avg.) and finished at 15th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
Signed-off-by: Alex Boten <[email protected]>
bogdandrutu
approved these changes
Dec 15, 2022
codeboten
deleted the
codeboten/make-updateotel-fdef8b181a06a90bd6da5e7ce59d94ecf2939027
branch
December 15, 2022 03:20
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/configschema
configschema command
cmd/mdatagen
mdatagen command
cmd/otelcontribcol
otelcontribcol command
cmd/oteltestbedcol
confmap/provider/s3provider
exporter/alibabacloudlogservice
Alibaba components
exporter/awscloudwatchlogs
awscloudwatchlogs exporter
exporter/awsemf
awsemf exporter
exporter/awskinesis
exporter/awsxray
exporter/azuredataexplorer
exporter/azuremonitor
exporter/carbon
exporter/clickhouse
exporter/coralogix
exporter/datadog
Datadog components
exporter/dynatrace
exporter/elasticsearch
exporter/f5cloud
F5 exporter
exporter/file
exporter/googlecloud
exporter/googlecloudpubsub
exporter/googlemanagedprometheus
Google Managed Prometheus exporter
exporter/humio
exporter/influxdb
exporter/instana
exporter/jaeger
exporter/jaegerthrifthttp
exporter/kafka
exporter/loadbalancing
exporter/logicmonitor
exporter/logzio
exporter/loki
Loki Exporter
exporter/mezmo
exporter/opencensus
exporter/parquet
exporter/prometheus
exporter/prometheusremotewrite
exporter/pulsar
exporter/sapm
exporter/sentry
exporter/signalfx
exporter/skywalking
exporter/splunkhec
exporter/sumologic
exporter/tanzuobservability
exporter/tencentcloudlogservice
exporter/zipkin
extension/asapauth
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first in a series of commit to bring core dependency up to main
component.MakeProcessorFactoryMap -> processor.MakeFactoryMap component.ProcessorFactory -> processor.Factory
componenttest.NewNopProcessorCreateSettings -> processortest.NewNopCreateSettings component.TracesProcessor -> processor.Traces
component.MetricsProcessor -> processor.Metrics
component.LogsProcessor -> processor.Logs
component.NewProcessorFactory -> processor.NewFactory
Signed-off-by: Alex Boten [email protected]