-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/transform] Fix panic when transforming span events #16622
Merged
bogdandrutu
merged 2 commits into
open-telemetry:main
from
TylerHelmuth:tp-fix-spanevent-bug
Dec 5, 2022
Merged
[processor/transform] Fix panic when transforming span events #16622
bogdandrutu
merged 2 commits into
open-telemetry:main
from
TylerHelmuth:tp-fix-spanevent-bug
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foresight Summary
View More Details⭕ tracegen workflow has finished in 7 minutes 43 seconds (
|
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
⭕ check-links workflow has finished in 7 minutes 53 seconds (⚠️ 5 minutes 31 seconds more than main
branch avg.) and finished at 5th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
⭕ prometheus-compliance-tests workflow has finished in 7 minutes 56 seconds and finished at 5th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 13 minutes 30 seconds (20 minutes 10 seconds less than main
branch avg.) and finished at 5th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
❌ changelog workflow has finished in 23 minutes 23 seconds (⚠️ 18 minutes 13 seconds more than main
branch avg.) and finished at 5th Dec, 2022. 0 job failed.
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 1 hour 14 minutes 16 seconds (⚠️ 59 minutes 14 seconds more than main
branch avg.) and finished at 5th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
loadtest (TestIdleMode) | - 🔗 | N/A | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | N/A | See Details |
loadtest (TestTraceAttributesProcessor) | - 🔗 | N/A | See Details |
build-and-test workflow has finished in 1 hour 28 minutes 14 seconds (⚠️ 31 minutes 43 seconds more than main
branch avg.) and finished at 5th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
unittest-matrix (1.19, internal) | N/A | ✅ 592 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-traces | N/A | ✅ 0 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, processor) | N/A | ✅ 1466 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, extension) | N/A | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, processor) | N/A | ✅ 1466 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-0) | N/A | ✅ 2532 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, exporter) | N/A | ✅ 2412 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, exporter) | N/A | ✅ 2412 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-0) | N/A | ✅ 2532 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, internal) | N/A | ✅ 592 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | N/A | ✅ 4354 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-1) | N/A | ✅ 1845 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, other) | N/A | ✅ 4355 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | N/A | ✅ 1845 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-metrics | N/A | ✅ 0 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, extension) | N/A | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
integration-tests | N/A | ✅ 59 ❌ 0 ⏭ 0 🔗 | See Details |
*You can configure Foresight comments in your organization settings page.
Aneurysm9
approved these changes
Dec 5, 2022
evan-bradley
approved these changes
Dec 5, 2022
codeboten
approved these changes
Dec 5, 2022
bogdandrutu
approved these changes
Dec 5, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
processor/transform
Transform processor
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug that would cause the collector to panic when transforming span events
Testing:
Added new unit test