Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/transform] Fix panic when transforming span events #16622

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

TylerHelmuth
Copy link
Member

Description:
Fixes a bug that would cause the collector to panic when transforming span events

Testing:
Added new unit test

@runforesight
Copy link

runforesight bot commented Dec 5, 2022

Foresight Summary

    
Major Impacts

build-and-test duration(43 minutes 48 seconds) has decreased 12 minutes 5 seconds compared to main branch avg(55 minutes 53 seconds).
View More Details

⭕  tracegen workflow has finished in 7 minutes 43 seconds (⚠️ 4 minutes 58 seconds more than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

⭕  check-links workflow has finished in 7 minutes 53 seconds (⚠️ 5 minutes 31 seconds more than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

⭕  prometheus-compliance-tests workflow has finished in 7 minutes 56 seconds and finished at 5th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 13 minutes 30 seconds (20 minutes 10 seconds less than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

❌  changelog workflow has finished in 23 minutes 23 seconds (⚠️ 18 minutes 13 seconds more than main branch avg.) and finished at 5th Dec, 2022. 0 job failed.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  load-tests workflow has finished in 1 hour 14 minutes 16 seconds (⚠️ 59 minutes 14 seconds more than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
loadtest (TestIdleMode) -     🔗  N/A See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  N/A See Details
loadtest (TestTraceAttributesProcessor) -     🔗  N/A See Details

 build-and-test workflow has finished in 1 hour 28 minutes 14 seconds (⚠️ 31 minutes 43 seconds more than main branch avg.) and finished at 5th Dec, 2022.


Job Failed Steps Tests
unittest-matrix (1.19, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1466  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 1466  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2532  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2412  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2412  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2532  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4354  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) N/A  ✅ 1845  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4355  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1845  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics N/A  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 59  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@github-actions github-actions bot added the processor/transform Transform processor label Dec 5, 2022
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Dec 5, 2022
@bogdandrutu bogdandrutu merged commit 05bcb42 into open-telemetry:main Dec 5, 2022
@TylerHelmuth TylerHelmuth deleted the tp-fix-spanevent-bug branch December 5, 2022 20:09
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/transform Transform processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants