Update datadog exporter codeowners #16554
Conversation
Add myself as a code owner
djaglowski
added
exporter/datadog
|
@evan-bradley, should this have pinged the codeowners once I added the component tag? |
|
@KSerrania @mx-psi @gbbr @knusbaum @amenasria @dineshg13, please confirm. |
The workflow should add code owners as reviewers to a PR once the label is added, but unfortunately GitHub doesn't allow adding reviewers who are not OpenTelemetry organization members, which is what happened here. There's an open issue to track leaving a comment to ping code owners in these cases here: #16326. |
There was a problem hiding this comment.
LGTM, but @liustanley is not a member of the OTel org, so we should probably figure that out first before merging this.
I think only two out of the six listed here are not members, did it fail because of those two? I would have expected the other four to be added 🤔 |
The workflow adds all reviewers in a single request to keep API calls to a minimum. If any single user in the request is not a member, the whole request will fail and no reviewers will be added. |
There was a problem hiding this comment.
LGTM, but @liustanley is not a member of the OTel org, so we should probably figure that out first before merging this.
@mx-psi did you want to block the PR until this is resolved?
|
We've enforced this CODEOWNER requirement before, I don't think we should bend the rules in this case. The requirement is there so that assignments can work. |
Sure, to clarify I was mostly asking @mx-psi to block the PR until that was resolved :D |
|
@mx-psi and I have talked about this situation before, it's a bit of a catch-22 haha |
mx-psi
dismissed
their stale review
Should have been a comment, not an approval
@codeboten I meant to comment instead of approving. I have talked about this with @TylerHelmuth before, I don't feel like it is a big deal to have codeowners that are not org members, but I don't think I should ignore the rules just because I don't agree with them 😄 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Foresight Summary
View More Details✅ tracegen workflow has finished in 1 minute 3 seconds (2 minutes 44 seconds less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| publish-latest | - 🔗 | N/A | See Details |
| build-dev | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ telemetrygen workflow has finished in 1 minute 8 seconds (1 minute 26 seconds less than main branch avg.) and finished at 1st Feb, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| build-dev | - 🔗 | N/A | See Details |
| publish-latest | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 49 seconds (1 minute 8 seconds less than main branch avg.) and finished at 1st Feb, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changed files | - 🔗 | N/A | See Details |
| check-links | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 18 seconds (4 minutes 29 seconds less than main branch avg.) and finished at 1st Feb, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
⭕ changelog workflow has finished in 5 seconds (2 minutes 1 second less than main branch avg.) and finished at 1st Feb, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changelog | - 🔗 | N/A | See Details |
✅ build-and-test workflow has finished in 37 minutes 59 seconds (15 minutes 22 seconds less than main branch avg.) and finished at 1st Feb, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| unittest-matrix (1.19, internal) | - 🔗 | ✅ 561 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, internal) | - 🔗 | ✅ 561 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, processor) | - 🔗 | ✅ 1471 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, extension) | - 🔗 | ✅ 546 ❌ 0 ⏭ 0 🔗 | See Details |
| correctness-metrics | - 🔗 | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
| correctness-traces | - 🔗 | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, processor) | - 🔗 | ✅ 1471 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, extension) | - 🔗 | ✅ 546 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, receiver-0) | - 🔗 | ✅ 2577 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, receiver-0) | - 🔗 | ✅ 2577 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, exporter) | - 🔗 | ✅ 2426 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, exporter) | - 🔗 | ✅ 2426 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, receiver-1) | - 🔗 | ✅ 1944 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, receiver-1) | - 🔗 | ✅ 1944 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.19, other) | - 🔗 | ✅ 4663 ❌ 0 ⏭ 0 🔗 | See Details |
| unittest-matrix (1.18, other) | - 🔗 | ✅ 4663 ❌ 0 ⏭ 0 🔗 | See Details |
| integration-tests | - 🔗 | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
| setup-environment | - 🔗 | N/A | See Details |
| check-codeowners | - 🔗 | N/A | See Details |
| build-examples | - 🔗 | N/A | See Details |
| checks | - 🔗 | N/A | See Details |
| lint-matrix (processor) | - 🔗 | N/A | See Details |
| lint-matrix (extension) | - 🔗 | N/A | See Details |
| check-collector-module-version | - 🔗 | N/A | See Details |
| lint-matrix (receiver-0) | - 🔗 | N/A | See Details |
| lint-matrix (other) | - 🔗 | N/A | See Details |
| lint-matrix (internal) | - 🔗 | N/A | See Details |
| lint-matrix (exporter) | - 🔗 | N/A | See Details |
| lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
| lint | - 🔗 | N/A | See Details |
| unittest (1.19) | - 🔗 | N/A | See Details |
| unittest (1.18) | - 🔗 | N/A | See Details |
| cross-compile (darwin, amd64) | - 🔗 | N/A | See Details |
| cross-compile (darwin, arm64) | - 🔗 | N/A | See Details |
| cross-compile (linux, 386) | - 🔗 | N/A | See Details |
| cross-compile (linux, amd64) | - 🔗 | N/A | See Details |
| cross-compile (linux, arm) | - 🔗 | N/A | See Details |
| cross-compile (linux, arm64) | - 🔗 | N/A | See Details |
| cross-compile (linux, ppc64le) | - 🔗 | N/A | See Details |
| cross-compile (windows, 386) | - 🔗 | N/A | See Details |
| cross-compile (windows, amd64) | - 🔗 | N/A | See Details |
| build-package (deb) | - 🔗 | N/A | See Details |
| build-package (rpm) | - 🔗 | N/A | See Details |
| windows-msi | - 🔗 | N/A | See Details |
| publish-check | - 🔗 | N/A | See Details |
| publish-dev | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 19 minutes 4 seconds (⚠️ 4 minutes 28 seconds more than main branch avg.) and finished at 1st Feb, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
| loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
| setup-environment | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 8 seconds (40 minutes 59 seconds less than main branch avg.) and finished at 1st Feb, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| windows-unittest-matrix | - 🔗 | N/A | See Details |
| windows-unittest | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
added
never stale
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Per open-telemetry/community/issues/1349 this can be merged after we fix the merge conflict 🎉 Welcome @liustanley :) let me know when the conflict is addressed. |
|
Added @songy23 as a codeowner as well since he's also on our team |
Add myself as a code owner