Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Add guidelines for Makefile development #16497

Merged
merged 1 commit into from
Nov 29, 2022
Merged

[chore] Add guidelines for Makefile development #16497

merged 1 commit into from
Nov 29, 2022

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski marked this pull request as ready for review November 28, 2022 17:06
@djaglowski djaglowski requested a review from a team as a code owner November 28, 2022 17:06
@djaglowski djaglowski merged commit b235e27 into open-telemetry:main Nov 29, 2022
@djaglowski djaglowski deleted the makefile-guidelines branch November 29, 2022 18:03
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@djaglowski @shalper2
[chore] Add guidelines for Makefile development (open-telemetry#16497)
fb989be
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@dashpole dashpole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposed guidelines for scoping of Make targets
3 participants
@djaglowski @jpkrohling @dashpole