[receiver/apache]: change feature gates for server name and port resource attributes to beta #16483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboguszewski-sumo
requested review from
a team and
djaglowski
as code owners
aboguszewski-sumo
changed the title
|
@aboguszewski-sumo I think a changelog entry would be useful for this situations to tell users of the component that the featuregate switched. |
aboguszewski-sumo
force-pushed
the
apache-beta
branch
2 times, most recently
from
3b2427c
to
f412376
Compare
aboguszewski-sumo
changed the title
aboguszewski-sumo
force-pushed
the
apache-beta
branch
from
f412376
to
1d93d23
Compare
|
@MovieStoreGuy I can't see your comment, but I saw it via email - yes, the issue number had a typo (14971 instead of 14791), thanks for catching that. |
djaglowski
approved these changes
Nov 29, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…urce attributes to beta (open-telemetry#16483) chore: change apachereceiver's feature gates to beta
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The feature gates in apachereceiver were supposed to be changed to Beta in
v0.66.0, but because this version has been released earlier than expected, the change was not included in this version.Does this need a changelog entry? Is this a breaking change in that case?
Link to tracking Issue: #14791
Testing:
Unit and integration tests. Integration tests have this feature disabled.
Documentation:
Readme has been updated.