Remove duplicate parse IDs code, avoid coreinternal dependency #16393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
a team,
TylerHelmuth,
evan-bradley and
jpkrohling
as code owners
github-actions
bot
added
pkg/ottl
processor/routing
TylerHelmuth
approved these changes
Nov 21, 2022
evan-bradley
approved these changes
Nov 21, 2022
The main reason to do this, is to allow coreinternal/processor/filter* to use ottl. Signed-off-by: Bogdan Drutu <[email protected]>
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…telemetry#16393) The main reason to do this, is to allow coreinternal/processor/filter* to use ottl. Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Bogdan Drutu <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason to do this, is to allow coreinternal/processor/filter* to use ottl.
Signed-off-by: Bogdan Drutu [email protected]