[chore] Update instructions to run E2E tests #16084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Nov 4, 2022
|
@evan-bradley there are some links to update |
dmitryax
approved these changes
Nov 4, 2022
|
@evan-bradley can you please also update all the links reported by |
c9d871c
to
6a05d5f
Compare
dineshg13
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
Update the instructions to run the E2E tests to use the Make target. I chose to use the e2e-test Make target since it will guarantee the local Collector binary is generated and up to date. I also removed the output screenshots since I think they likely don't provide much value.
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
Update the instructions to run the E2E tests to use the Make target. I chose to use the e2e-test Make target since it will guarantee the local Collector binary is generated and up to date. I also removed the output screenshots since I think they likely don't provide much value.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update the instructions to run the E2E tests to use the Make target.
I chose to use the
e2e-testMake target since it will guarantee the local Collector binary is generated and up to date. I also removed the output screenshots since I think they likely don't provide much value.Link to tracking Issue:
Fixes #14975
Documentation:
Updated the testbed readme.