Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples/demo] Reduce demo image size #15999

Merged
merged 12 commits into from
Nov 1, 2022
Merged

[examples/demo] Reduce demo image size #15999

merged 12 commits into from
Nov 1, 2022

Conversation

JaredTan95
Copy link
Member

Description:

  • before:
$ docker images                                                    
REPOSITORY         TAG   IMAGE ID    CREATED    SIZE
demo_demo-server         latest     58dbd4137fd7   7 minutes ago   1.25GB
  • after:
$ docker images                                                
REPOSITORY        TAG    IMAGE ID    CREATED   SIZE
demo_demo-client    latest    079046a22362   39 seconds ago       21.7MB
demo_demo-server     latest    22d9b9100a45   About a minute ago   22.6MB

Link to tracking Issue:

Testing:

Documentation:

@JaredTan95
remove warning
6a294d5 
Signed-off-by: jian.tan <[email protected]>
@JaredTan95
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
3129b08 
…y-collector-contrib
@JaredTan95
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
a283c17 
…y-collector-contrib
@JaredTan95
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
7fa90ac 
…y-collector-contrib
@JaredTan95
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
9c89de6 
…y-collector-contrib
@JaredTan95
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
90d7c76 
…y-collector-contrib
@JaredTan95
fix TestExporter_PushTraceRecord Flaky test
cdddd47
@JaredTan95
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
50c8653 
…y-collector-contrib
@JaredTan95
Merge remote-tracking branch 'upstream/main'
c4e9d50
@JaredTan95
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
24039f0 
…y-collector-contrib
@JaredTan95
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
c7016fe 
…y-collector-contrib
@JaredTan95
Reduce the demo image size
788c35b
@JaredTan95 JaredTan95 requested review from a team as code owners November 1, 2022 08:01
@JaredTan95 JaredTan95 changed the title Reduce demo image size [examples/demo] Reduce demo image size Nov 1, 2022
@JaredTan95
Copy link
Member Author

/skip-changelog

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 1, 2022
codeboten
codeboten approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @JaredTan95

@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Nov 1, 2022
@codeboten codeboten added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Nov 1, 2022
@bogdandrutu bogdandrutu merged commit 099ad78 into open-telemetry:main Nov 1, 2022
@JaredTan95 JaredTan95 deleted the reduce_demo_image_size branch November 2, 2022 00:49
@saurabhdes saurabhdes mentioned this pull request Nov 5, 2022
Closed
dineshg13 pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
@JaredTan95 @dineshg13
[examples/demo] Reduce demo image size (open-telemetry#15999)
f9f0030 
* remove warning

Signed-off-by: jian.tan <[email protected]>

* fix TestExporter_PushTraceRecord Flaky test

* Reduce the demo image size

Signed-off-by: jian.tan <[email protected]>
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@JaredTan95 @shalper2
[examples/demo] Reduce demo image size (open-telemetry#15999)
4d03d2d 
* remove warning

Signed-off-by: jian.tan <[email protected]>

* fix TestExporter_PushTraceRecord Flaky test

* Reduce the demo image size

Signed-off-by: jian.tan <[email protected]>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax dmitryax approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@Aneurysm9 Aneurysm9

Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JaredTan95 @codeboten @dmitryax @Aneurysm9 @bogdandrutu @djaglowski