Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Allow adding component labels through comments #15719

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Oct 31, 2022

Description:

This adds the ability to add and remove component labels using comments, which will allow issue openers to add the label corresponding to a component to ping the code owners, and will enable code owners to update the component labels on an issue if necessary.

There are two relatively minor caveats with the way the add-labels.sh script is currently implemented.

  • Labels and comments are added separately, so adding a lot of labels can make things noisy. This can be fixed with additional processing, but I figure this is an uncommon case, so I opted to instead keep the script simple.
  • Adding a component label that already is applied will ping the code owners again.

Link to tracking Issue:

Fixes #15684

Testing:

I've tested this on my fork.

Documentation:

Updated the documentation on adding labels.

@evan-bradley
Copy link
Contributor Author

Please take a look @open-telemetry/collector-contrib-approvers @open-telemetry/collector-contrib-triagers.

@evan-bradley
Copy link
Contributor Author

evan-bradley commented Oct 31, 2022

As part of this, I am also temporarily shortening the time between an issue being marked stale and closed to 60 days to expedite closing out the very old issues in the backlog. This should close out the oldest issues roughly by the start of next year. Issues that are determined to still be relevant after this period can be reopened. After the current backlog of stale issues is processed, we can restore the 120 day period between being marked stale and being closed.
See #15994.

@dmitryax
Copy link
Member

@evan-bradley can you please keep this PR to one purpose, so it only adds the ability to add/remove labels with comments? Other staleness adjustments should go in different PRs since they seem not closely related.

@evan-bradley
Copy link
Contributor Author

@dmitryax That's fine with me. Please see #15994.

@dmitryax
Copy link
Member

dmitryax commented Nov 1, 2022

@evan-bradley thanks! Please update this PR as well

@evan-bradley evan-bradley force-pushed the add-component-labels branch 2 times, most recently from 0d6f67e to b56f836 Compare November 1, 2022 13:27
@evan-bradley
Copy link
Contributor Author

@dmitryax Everything should be in order now.

@dmitryax dmitryax merged commit 6e66d7a into open-telemetry:main Nov 1, 2022
dineshg13 pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
…y#15719)

This adds the ability to add and remove component labels using comments, which will allow issue openers to add the label corresponding to a component to ping the code owners, and will enable code owners to update the component labels on an issue if necessary.

There are two relatively minor caveats with the way the add-labels.sh script is currently implemented.

- Labels and comments are added separately, so adding a lot of labels can make things noisy. This can be fixed with additional processing, but I figure this is an uncommon case, so I opted to instead keep the script simple.
- Adding a component label that already is applied will ping the code owners again.
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…y#15719)

This adds the ability to add and remove component labels using comments, which will allow issue openers to add the label corresponding to a component to ping the code owners, and will enable code owners to update the component labels on an issue if necessary.

There are two relatively minor caveats with the way the add-labels.sh script is currently implemented.

- Labels and comments are added separately, so adding a lot of labels can make things noisy. This can be fixed with additional processing, but I figure this is an uncommon case, so I opted to instead keep the script simple.
- Adding a component label that already is applied will ping the code owners again.
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[admin] mark-issues-as-stale.sh not grabbing enough issues
4 participants