Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/metricstransformprocessor] Add operation for conversion of camel case metric names to snake case #15379

Closed
wants to merge 21 commits into from
Closed

[processor/metricstransformprocessor] Add operation for conversion of camel case metric names to snake case #15379

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6e8616c
Add functions for snake case
clarkjohnd Oct 9, 2022
2c90eb3
Add basic test cases
clarkjohnd Oct 9, 2022
467ebfb
Merge branch 'main' into snake-case
clarkjohnd Oct 9, 2022
8f56b63
Merge branch 'main' into snake-case
clarkjohnd Oct 20, 2022
9649c74
Update tests
clarkjohnd Oct 20, 2022
3e18c76
Reference gist
clarkjohnd Oct 20, 2022
100d3b9
Update test
clarkjohnd Oct 20, 2022
824daea
Merge branch 'main' into snake-case
clarkjohnd Oct 20, 2022
089329d
Rename stuff
clarkjohnd Oct 21, 2022
b6d719c
Change from configAction to operationAction
clarkjohnd Oct 21, 2022
9a6a7cd
Update tests to new operationAction style
clarkjohnd Oct 21, 2022
46db1dd
Merge branch 'main' into snake-case
clarkjohnd Oct 21, 2022
675abef
Add config tests
clarkjohnd Oct 21, 2022
9312ca8
Update README
clarkjohnd Oct 21, 2022
81ee69f
Add licence
clarkjohnd Oct 21, 2022
64bd963
Merge branch 'main' into metric-convert-to-snake-case
clarkjohnd Oct 21, 2022
d4f926a
Fix readme
clarkjohnd Oct 21, 2022
9758f7d
Tidy up
clarkjohnd Oct 21, 2022
1174d97
Add changelog
clarkjohnd Oct 21, 2022
82b5b36
Merge branch 'open-telemetry:main' into metric-convert-to-snake-case
clarkjohnd Oct 27, 2022
ecc46d8
Merge branch 'open-telemetry:main' into metric-convert-to-snake-case
clarkjohnd Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests to new operationAction style 
Signed-off-by: John Clark <[email protected]>
  • Loading branch information
@clarkjohnd
clarkjohnd committed Oct 21, 2022
commit 9a6a7cd4795a5d950d8e48acbfab70c52d1b26a0
96 changes: 78 additions & 18 deletions processor/metricstransformprocessor/metrics_transform_processor_testcases_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,11 +1611,18 @@ var (
out: []pmetric.Metric{},
},
{
name: "simple_convert_to_snake_case",
name: "strict_convert_to_snake_case",
transforms: []internalTransform{
{
MetricIncludeFilter: internalFilterStrict{include: "metric"},
Action: CaseConvert,
MetricIncludeFilter: internalFilterStrict{include: "metricTest"},
Action: Update,
Operations: []internalOperation{
{
configOperation: Operation{
Action: CaseConvert,
},
},
},
},
},
in: []pmetric.Metric{
Expand All @@ -1626,41 +1633,87 @@ var (
},
},
{
name: "complex_convert_to_snake_case",
name: "regexp_convert_to_snake_case",
transforms: []internalTransform{
{
MetricIncludeFilter: internalFilterStrict{include: "metric"},
Action: CaseConvert,
MetricIncludeFilter: internalFilterRegexp{include: regexp.MustCompile(".*")},
Action: Update,
Operations: []internalOperation{
{
configOperation: Operation{
Action: CaseConvert,
},
},
},
},
},
in: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeGauge, "metricTest").build(),
},
out: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeGauge, "metric_test").build(),
},
},
// Only convert to snake case metrics starting with test
{
name: "complex_regexp_convert_to_snake_case",
transforms: []internalTransform{
{
MetricIncludeFilter: internalFilterRegexp{include: regexp.MustCompile("test.*[A-Z]")},
Action: Update,
Operations: []internalOperation{
{
configOperation: Operation{
Action: CaseConvert,
},
},
},
},
},
in: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeGauge, "Base_MetricTest").build(),
metricBuilder(pmetric.MetricTypeGauge, "testMetric").build(),
metricBuilder(pmetric.MetricTypeGauge, "Metric").build(),
},
out: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeGauge, "base_metric_test").build(),
metricBuilder(pmetric.MetricTypeGauge, "test_metric").build(),
metricBuilder(pmetric.MetricTypeGauge, "Metric").build(),
},
},
{
name: "no_change_convert_to_snake_case",
transforms: []internalTransform{
{
MetricIncludeFilter: internalFilterStrict{include: "metric"},
Action: CaseConvert,
MetricIncludeFilter: internalFilterRegexp{include: regexp.MustCompile(".*")},
Action: Update,
Operations: []internalOperation{
{
configOperation: Operation{
Action: CaseConvert,
},
},
},
},
},
in: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeGauge, "simple_metric").build(),
metricBuilder(pmetric.MetricTypeGauge, "metric_test").build(),
},
out: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeGauge, "simple_metric").build(),
metricBuilder(pmetric.MetricTypeGauge, "metric_test").build(),
},
},
{
name: "multiple_uppercase_convert_to_snake_case",
transforms: []internalTransform{
{
MetricIncludeFilter: internalFilterStrict{include: "metric"},
Action: CaseConvert,
MetricIncludeFilter: internalFilterRegexp{include: regexp.MustCompile(".*")},
Action: Update,
Operations: []internalOperation{
{
configOperation: Operation{
Action: CaseConvert,
},
},
},
},
},
in: []pmetric.Metric{
Expand All @@ -1674,15 +1727,22 @@ var (
name: "dash_replacement_convert_to_snake_case",
transforms: []internalTransform{
{
MetricIncludeFilter: internalFilterStrict{include: "metric"},
Action: CaseConvert,
MetricIncludeFilter: internalFilterRegexp{include: regexp.MustCompile(".*")},
Action: Update,
Operations: []internalOperation{
{
configOperation: Operation{
Action: CaseConvert,
},
},
},
},
},
in: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeGauge, "simple-metric").build(),
metricBuilder(pmetric.MetricTypeGauge, "metric-test").build(),
},
out: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeGauge, "simple_metric").build(),
metricBuilder(pmetric.MetricTypeGauge, "metric_test").build(),
},
},
}
Expand Down