[processor/{deltatorate, metricsgeneration}] Add CODEOWNERS #15375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
changed the title
Aneurysm9
approved these changes
Oct 21, 2022
TylerHelmuth
requested changes
Oct 21, 2022
There was a problem hiding this comment.
As much as I'd like code owners on everything, I do think we should adhere to the guidelines we setup for ourselves, which require code owners to be OpenTelemetry community members.
|
I hadn't realized that Rayhan was not a member, PTAL |
|
Also @Aneurysm9 please then confirm that you would be okay being the single owner of these components |
TylerHelmuth
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
@hossain-rayhan if you are interested in becoming a code owner checkout https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner, we'd love the help!
Aneurysm9
approved these changes
Oct 21, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…emetry#15375) * [processor/deltatorate] Add CODEOWNERS * Also add `metricsgeneration` * Update ALLOWLIST * Remove @hossain-rayan
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add CODEOWNERs for the deltatorate and metricsgeneration processors, based on the authors of #4218 and #3266 respectively.
Link to tracking Issue: Updates #3870