[exporter/mezmo] Fix HTTP client settings usage #15246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is anyone able to take a look at this? |
jsumners
force-pushed
the
mezmo/tls-config
branch
from
a8387e4
to
3ad21ca
Compare
jsumners
force-pushed
the
mezmo/tls-config
branch
from
3ad21ca
to
66394ea
Compare
|
All required CI is green 👍 |
|
Is there anything I need to address before this can be merged? |
dashpole
approved these changes
Oct 31, 2022
|
@dashpole for reference, I am part of the same organization as those individuals. In fact, Greg Janco is my manager. |
billmeyer
approved these changes
Oct 31, 2022
dashpole
added
the
ready to merge
|
@jsumners thanks. I'll try to remember, but no promises ;). I'm just the approver "sponsor" of the component, and while I can do reviews, I prefer to let the other codeowners from the component review before merging a PR. If the existing codeowners want, you can be added as a codeowner as well. But I generally rely on the codeowners files to tell me who I need to ping for reviews when I forget who works on what. |
codeboten
approved these changes
Oct 31, 2022
|
Thanks folks. |
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
Previously, the mezmoexporter was ignoring any settings provided by way of https://github.com/open-telemetry/opentelemetry-collector/tree/4d445807f9eca3af660bec2a3fb4ca3518cd255d/config/confighttp. This PR fixes that mistake.
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, the
mezmoexporterwas ignoring any settings provided by way of https://github.com/open-telemetry/opentelemetry-collector/tree/4d445807f9eca3af660bec2a3fb4ca3518cd255d/config/confighttp. This PR fixes that mistake.Link to tracking Issue: N/A
Testing:
Documentation: