-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pure Storage Flash Array receiver #14969
Pure Storage Flash Array receiver #14969
Conversation
cc @jpkrohling |
sorry, this is still missing some things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add this component also to other plumbing places, like dependabot and code owners. We might have a guide with the requirements for the initial commit. If not, let me know and I'll find a good example to follow.
The CI is failing with:
You can reproduce it locally with
|
Yes, thank you @jpkrohling. I am already working on these files with this behavior (blank files), until the end of the day they will be filled then the CI (I hope) will make the correct lint |
@jpkrohling since your review, seem to be lots of changes, can you do another round and merge the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started reviewing it again, but not sure it's ready for review. @dgoscn, can you please confirm? I think there's value in having a PR with the config only and the basic skeleton, with the implementation for the array scraper being on the next PR.
revoking approval, as the PR has changed
3322c55
to
8bcedf3
Compare
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Description:
New Pure Storage FlashArray receiver component
Link to tracking Issue:
#14886
Testing:
Simple functional testing as with other components
Documentation:
The documentation is not ready at the moment, but will be displayed on README.md alongside with documentation.md inside the
receiver/purefareceiver
project