Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/elasticsearch]: add translog metrics on index level #14923

Merged

Conversation

aboguszewski-sumo
Copy link
Member

Description:
Translog metrics (size and number of operations) have been added on index level with total shard aggregation.
Similar metrics already exist for node level, so I tried to keep them as similar as possible.

Link to tracking Issue: #14635

Testing:
Unit and integration tests

Documentation:
mdatagen

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data model and implementation look good, but please mark the metrics as disabled by default.

@aboguszewski-sumo
Copy link
Member Author

Metrics are now disabled by default.

@djaglowski
Copy link
Member

Please rebase

@aboguszewski-sumo
Copy link
Member Author

Rebased.

@djaglowski djaglowski merged commit b737b99 into open-telemetry:main Oct 31, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants