Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @kbrockhoff as an Approver #1492

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Add @kbrockhoff as an Approver #1492

merged 1 commit into from
Nov 4, 2020

Conversation

tigrannajaryan
Copy link
Member

No description provided.

@tigrannajaryan tigrannajaryan requested a review from a team as a code owner November 4, 2020 15:56
bogdandrutu
bogdandrutu reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the approver to the list of auto-assign as well.

@tigrannajaryan
Copy link
Member Author

Please add the approver to the list of auto-assign as well.

Done.

@bogdandrutu bogdandrutu merged commit 59a1114 into open-telemetry:master Nov 4, 2020
@tigrannajaryan
Copy link
Member Author

@kbrockhoff Congrats! It may be worth re-reading the contribution guidelines so that you can enforce them as an Approver and also see the recently added description of approver-as-facilitator here https://github.com/open-telemetry/opentelemetry-collector-contrib#prs-and-reviews

@tigrannajaryan tigrannajaryan deleted the feature/tigran/add-approver branch November 4, 2020 18:10
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@mothershipper
Adds semantic conventions for exceptions (#1492)
33699d2 
Adds support for the opentelemetry exceptions semantic conventions. In
short, this has RecordError produce an exception event with exception
attributes instead of using the error event and error attributes.

While golang does not have exceptions, the spec itself does not
differentiate between errors and exceptions for recording purposes.
RecordError was kept as the method name, both for backwards
compatibility and to reduce confusion (the method signature takes in a
golang error object). The spec appears to allow this, as it suggests the
method is optional and signature may reflect whatever is most appropriate
for the language implementing it.

It may seem non-intuitive to log an exception event from a method called
RecordError, but it's beneficial to have consistent behavior across all
opentelemetry SDKs. Downstream projects like the opentelemetry-collector
can build off of the published API and not special case behaviors from
individual languages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@kbrockhoff kbrockhoff kbrockhoff approved these changes

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tigrannajaryan @jpkrohling @bogdandrutu @kbrockhoff