[receiver/elasticsearch]: add metrics related to GET operations #14793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboguszewski-sumo
force-pushed
the
elastic_get_ops
branch
from
c852dee
to
2978638
Compare
djaglowski
reviewed
Oct 10, 2022
aboguszewski-sumo
force-pushed
the
elastic_get_ops
branch
from
571187c
to
9ee4a15
Compare
|
This seems outdated: If I'm counting correctly, after adding these new metrics, there are 110 different Record* calls in scrapeNodeMetrics, but some are version dependent etc. so I'm not sure if it's the number we should add.
|
aboguszewski-sumo
force-pushed
the
elastic_get_ops
branch
from
9ee4a15
to
8809629
Compare
|
Rebased after one test file has been removed. |
dmitryax
reviewed
Oct 20, 2022
aboguszewski-sumo
force-pushed
the
elastic_get_ops
branch
from
8809629
to
138bfe4
Compare
|
The metrics are now disabled by default. |
aboguszewski-sumo
requested review from
dmitryax and
djaglowski
and removed request for
djaglowski and
dmitryax
djaglowski
approved these changes
Nov 3, 2022
dineshg13
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…-telemetry#14793) feat: add metrics related to GET operations
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…-telemetry#14793) feat: add metrics related to GET operations
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
New metrics have been added. However, I think that they're a bit troublesome to add. They are metrics that reflect how many GET operations ended up with success (
exists), how many ended up with failure(missing) and time spent on these operations.Currently (on main) only total sum of these two values is being sent as
elasticsearch.node.operations.*metrics withgetattribute. This is the main reason why I think that adding them is not easy. I thought up of two solutions that wouldn't be breaking changes:get_existsandget_missing- it would not be a breaking change, but I feel that it doesn't look goodelasticsearch.node.operations.get.*- it is not consistent with how other metrics are organised, but neither breaks anything. Might seem unintuitive, because then total count would beelasticsearch.node.operations.completed, but total success count would beelasticsearch.node.operations.get.completed.I implemented the second one, but I'm open for discussion. If we don't mind breaking changes, then we could for example implement the first one and remove the total count, because
exists + missing = total.Link to tracking Issue: #14635
Testing:
Unit tests and integration tests.
Documentation:
Generated by
mdatagen.