Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Skip TestExporter_PushTraceRecord flasky test #14785

Merged
merged 7 commits into from
Oct 24, 2022

Conversation

JaredTan95
Copy link
Member

Description: fix #14759

Link to tracking Issue: #14759

Testing:

Documentation:

@JaredTan95 JaredTan95 requested review from a team and jpkrohling October 8, 2022 07:23
@JaredTan95
Copy link
Member Author

/skip-changelog

@JaredTan95 JaredTan95 changed the title Fix es exporter flasky test Fix es exporter TestExporter_PushTraceRecord flasky test Oct 8, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 23, 2022
@JaredTan95
Copy link
Member Author

@dmitryax hi, do you have time to help review this?

@dmitryax dmitryax changed the title Fix es exporter TestExporter_PushTraceRecord flasky test Skip TestExporter_PushTraceRecord flasky test Oct 24, 2022
@dmitryax dmitryax changed the title Skip TestExporter_PushTraceRecord flasky test [exporter/elasticsearch] Skip TestExporter_PushTraceRecord flasky test Oct 24, 2022
@dmitryax dmitryax added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Stale labels Oct 24, 2022
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this is not a fix. Merging as a temporary remediation

@dmitryax dmitryax merged commit 66dd4e5 into open-telemetry:main Oct 24, 2022
@JaredTan95 JaredTan95 deleted the fix_es_exporter_flasky_test branch October 24, 2022 04:14
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/elasticsearch] Flaky test TestExporter_PushTraceRecord
2 participants