Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/snowflakereceiver] New Snowflake receiver #14778

Merged
merged 13 commits into from
Oct 19, 2022
Merged

[receiver/snowflakereceiver] New Snowflake receiver #14778

merged 13 commits into from
Oct 19, 2022

Conversation

shalper2
Copy link
Contributor

@shalper2 shalper2 commented Oct 7, 2022 •
edited by jpkrohling
Loading

Description:
New Snowflake receiver component

Link to tracking Issue:
Closes #14754

Testing:
Simple functional testing as with other components

Documentation:
Metrics to be generated with mdatagen and metadata.yaml.

@shalper2 shalper2 requested a review from a team as a code owner October 7, 2022 14:52
@jpkrohling jpkrohling requested review from dmitryax and removed request for bogdandrutu October 10, 2022 20:31
@jpkrohling jpkrohling assigned dmitryax and unassigned dashpole Oct 10, 2022
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 17, 2022
@dmitryax
Copy link
Member

dmitryax commented Oct 17, 2022 •
edited
Loading

Since this PR is pretty empty. I can merge it without a changelog entry. But please add a "new component" changelog entry in one of the next PRs https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/.chloggen

@dmitryax
Copy link
Member

@shalper2 looks like Makefile is missed

@dmitryax
Copy link
Member

The makefile shouldn't be empty. PTAL at other components

@dmitryax
Copy link
Member

Another failing check. the component must be listed in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/CODEOWNERS . Please mention your and my github handles there

@dmitryax
Copy link
Member

linter is failing due to missing package in go files. you can add the package or remove go files for now

@dmitryax
Copy link
Member

@shalper2 couple other checks are still failing, PTAL

dmitryax
dmitryax reviewed Oct 18, 2022
View reviewed changes
.github/ALLOWLIST Outdated Show resolved Hide resolved
dmitryax
dmitryax reviewed Oct 18, 2022
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@dmitryax
Copy link
Member

@shalper2 there is one last failing check , PTAL

@dmitryax dmitryax merged commit 7523480 into open-telemetry:main Oct 19, 2022
kovrus added a commit to kovrus/opentelemetry-collector-contrib that referenced this pull request Oct 19, 2022
@kovrus
[chore] Set go 1.18 for snowflake receiver.
6af1b87 
The collector build is broken by open-telemetry#14778
@kovrus kovrus mentioned this pull request Oct 19, 2022
Closed
shalper2 added a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@shalper2 @dmitryax
[receiver/snowflakereceiver] New Snowflake receiver skeleton (open-te…
342539c 
…lemetry#14778)

Co-authored-by: Dmitrii Anoshin <[email protected]>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@dmitryax dmitryax

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New component: Snowflake Receiver
3 participants
@shalper2 @dmitryax @dashpole