Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/mysql]: add metrics based on events_statements_summary_by_digest table #14770

Closed
wants to merge 1 commit into from
Closed

[receiver/mysql]: add metrics based on events_statements_summary_by_digest table #14770

wants to merge 1 commit into from

Conversation

sumo-drosiek
Copy link
Member

Description:

Add metrics based on table_lock_waits_summary_by_table table

mysql docs

This is going to add equivalents of the following telegraf metrics:

mysql_perf_schema_read
mysql_perf_schema_read_high_priority
mysql_perf_schema_read_no_insert
mysql_perf_schema_read_normal
mysql_perf_schema_read_with_shared_locks
mysql_perf_schema_write
mysql_perf_schema_write_allow_write
mysql_perf_schema_write_concurrent_insert
mysql_perf_schema_write_low_priority
mysql_perf_schema_write_normal

Link to tracking Issue: #14138

Testing: Units

Documentation: auto-generated

@sumo-drosiek sumo-drosiek requested review from a team and djaglowski as code owners October 7, 2022 07:28
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-locks-metrics branch 2 times, most recently from f0d8f53 to c2b8868 Compare October 10, 2022 13:17
djaglowski
djaglowski reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These metrics could potentially be very high cardinality (e.g. when there are many schemas and/or tables). Can we disable them by default?

receiver/mysqlreceiver/scraper_test.go Outdated Show resolved Hide resolved
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-locks-metrics branch 2 times, most recently from 0f2082c to e3b0143 Compare October 11, 2022 06:30
@sumo-drosiek @djaglowski
feat(receiver/mysql): add metrics based on table_lock_waits_summary_b…
bc939ee 
…y_table table

Signed-off-by: Dominik Rosiek <[email protected]>
Co-authored-by: Daniel Jaglowski <[email protected]>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-perf-locks-metrics branch from e3b0143 to bc939ee Compare October 11, 2022 07:19
@sumo-drosiek sumo-drosiek mentioned this pull request Oct 19, 2022
Merged
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 26, 2022
@portertech
Copy link
Contributor

@djaglowski looks like they are disabled by default, ready to rock?

@github-actions github-actions bot removed the Stale label Oct 27, 2022
@djaglowski
Copy link
Member

This looks good to me. Please resolve merge conflicts.

@sumo-drosiek sumo-drosiek mentioned this pull request Oct 31, 2022
Merged
@sumo-drosiek
Copy link
Member Author

@djaglowski added to #15366

@djaglowski
Copy link
Member

Closed based on #15366

@djaglowski djaglowski closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski left review comments

Assignees

@djaglowski djaglowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sumo-drosiek @portertech @djaglowski