Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exporter/datadogexporter: tidy up #14761

Merged
merged 4 commits into from
Oct 11, 2022
Merged

exporter/datadogexporter: tidy up #14761

merged 4 commits into from
Oct 11, 2022

Conversation

gbbr
Copy link
Member

@gbbr gbbr commented Oct 6, 2022

  • Rename "testutils" to "testutil", which is a more common name for *util suffixed pacakges (non plural)
  • Absorb "internal/sketches" package into "internal/metrics"
  • Absorb "internal/utils/cache" package into "internal/metadata", the only place where it is used. Make it unexported and document it.
  • Renamed "internal/utils" to "internal/clientutil" because it contains client utilities. "client" would have been a better name but it clashes with the variable extracted from CreateClient and makes usage difficult.

@gbbr gbbr requested a review from a team October 6, 2022 17:50
@gbbr gbbr requested a review from mx-psi as a code owner October 6, 2022 17:50
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 10, 2022
@gbbr
Tidy up some code:
95d146e 
* Rename "testutils" to "testutil"
* Absorb "internal/sketches" package into "internal/metrics"
* Absorb "internal/utils/cache" package into "internal/metadata", the
  only place where it is used. Make it unexported and document it.
* Renamed "internal/utils" to "internal/clientutil"
@gbbr
Move sketches files back into their own package.
3b27c58
@mx-psi mx-psi merged commit abcba31 into open-telemetry:main Oct 11, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@gbbr @shalper2
exporter/datadogexporter: tidy up (open-telemetry#14761)
462d540 
* Tidy up some code:

* Rename "testutils" to "testutil"
* Absorb "internal/sketches" package into "internal/metrics"
* Absorb "internal/utils/cache" package into "internal/metadata", the
  only place where it is used. Make it unexported and document it.
* Renamed "internal/utils" to "internal/clientutil"

* Move sketches files back into their own package.

* Move sketches import to its own block

* lint
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees

@mx-psi mx-psi

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbbr @mx-psi