Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/snmpreceiver] Add boilerplate skeleton for SNMP metric receiver #14714

Merged
merged 1 commit into from
Oct 6, 2022
Merged

[receiver/snmpreceiver] Add boilerplate skeleton for SNMP metric receiver #14714

merged 1 commit into from
Oct 6, 2022

Conversation

StefanKurek
Copy link
Contributor

@StefanKurek StefanKurek commented Oct 4, 2022

Description:
This is the boilerplate setup of the SNMP Receiver. It collects without erroring, but does not have any useful config or actually collect any SNMP data at this point.

Link to tracking Issue:
13409

Testing:
No unit or integration tests. Just manually ran to see if it worked.

Documentation:
README added for what the SNMP receiver will ultimately be.

@StefanKurek StefanKurek requested review from a team and mx-psi October 4, 2022 19:49
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two doc nits


The full list of settings exposed for this receiver are documented [here](./config.go) with detailed sample configurations [here](./testdata).

[beta]:https://github.com/open-telemetry/opentelemetry-collector#in-development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[beta]:https://github.com/open-telemetry/opentelemetry-collector#in-development
[in development]:https://github.com/open-telemetry/opentelemetry-collector#in-development


| Status | |
| ------------------------ |-----------|
| Stability | [in-development] |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Stability | [in-development] |
| Stability | [in development] |

@djaglowski
Copy link
Member

Looks like it needs a make gotidy as well

@StefanKurek StefanKurek requested review from djaglowski and removed request for mx-psi October 5, 2022 02:59
@djaglowski
Copy link
Member

It appears that internal/components/TestDefaultReceivers is failing:

=== RUN   TestDefaultReceivers
    receivers_test.go:358: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/components/receivers_test.go:358
        	Error:      	"[{active_directory_ds %!s(bool=true) %!s(components.getReceiverConfigFn=<nil>)} {aerospike %!s(bool=false) %!s(components.getReceiverConfigFn=<nil>)} {apache %!s(bool=false) %!s(components.getReceiverConfigFn=<nil>)} ...]" should have 73 item(s), but has 72
        	Test:       	TestDefaultReceivers
        	Messages:   	All receivers must be added to the lifecycle suite

@StefanKurek
Copy link
Contributor Author

Link to failure: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3191785503/jobs/5208530885#step:8:9653

@djaglowski ok, so the list of tests was always cut off for me. i had to expand/collapse them a couple times to get everything to show up.

@djaglowski djaglowski merged commit 6dc71bd into open-telemetry:main Oct 6, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants