[confmap.provider/s3provider] Rename from s3mapprovider to s3provider #14617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Oct 1, 2022
neelayu
force-pushed
the
s3provider
branch
2 times, most recently
from
5ff6e35
to
61fcf52
Compare
Aneurysm9
suggested changes
Oct 7, 2022
|
@Aneurysm9 thanks for the feedback. This PR now only contains rename changes. I'll create a separate PR which will modify the minor bits here and there. |
Aneurysm9
approved these changes
Oct 10, 2022
Aneurysm9
added
the
ready to merge
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…open-telemetry#14617) For consistency, its better to keep it as s3provider. Also improved comments in the code, few minor changes and added unit tests
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For consistency, its better to keep it as
s3provider. Also improved comments in the code, few minor changes and added unit testsLink to tracking Issue: #14616
Testing: Added a few unit tests to increase coverage
Documentation: Updated README.md