Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change zipkin V1 conversion to use pdata, removes one extra step #14592

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

bogdandrutu
Copy link
Member

No description provided.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do another round of review later today. For now only nits

pkg/translator/zipkin/zipkinv1/json.go Outdated Show resolved Hide resolved
pkg/translator/zipkin/zipkinv1/json.go Show resolved Hide resolved
pkg/translator/zipkin/zipkinv1/json.go Outdated Show resolved Hide resolved
pkg/translator/zipkin/zipkinv1/json.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit d31a5c3 into open-telemetry:main Sep 30, 2022
@bogdandrutu bogdandrutu deleted the zipkinoc branch September 30, 2022 15:41
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants