Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Change receiver config tests to unmarshal config only for that component. (part4) #14562

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

kovrus
Copy link
Member

@kovrus kovrus commented Sep 28, 2022

Description:

Change receivers config tests to unmarshal config only for that component.

  • pulsarreceiver
  • rabbitmqreceiver
  • redisreceiver
  • riakreceiver
  • saphanareceiver
  • sapmreceiver
  • signalfxreceiver
  • simpleprometheusreceiver
  • skywalkingreceiver
  • solacereceiver

Link to tracking Issue:
#13224

@kovrus kovrus changed the title [chore] Change receiver config tests to unmarshal config only for tha…t component. (part4) [chore] Change receiver config tests to unmarshal config only for that component. (part4) Sep 28, 2022
@kovrus kovrus marked this pull request as ready for review September 28, 2022 11:26
@kovrus
Copy link
Member Author

kovrus commented Sep 28, 2022

@dmitryax

@djaglowski
Copy link
Member

This appears to contain many of the same changes as part 3 (memcached -> postgresql).

@kovrus
Copy link
Member Author

kovrus commented Sep 28, 2022

This appears to contain many of the same changes as part 3 (memcached -> postgresql).

let me check, I might have messed smth up while splitting a big PR

…t component. (part4)

- [x] pulsarreceiver
- [x] rabbitmqreceiver
- [x] redisreceiver
- [x] riakreceiver
- [x] saphanareceiver
- [x] sapmreceiver
- [x] signalfxreceiver
- [x] simpleprometheusreceiver
- [x] skywalkingreceiver
- [x] solacereceiver
@kovrus
Copy link
Member Author

kovrus commented Sep 28, 2022

dropped memcached and postgresqlreceiver changes.

@djaglowski
Copy link
Member

I should have been more clear, but I meant to point out the whole range of receivers between memcached and postgresql, everything before pulsar. Really it doesn't matter that much but it'll allow for quicker approval and avoid a rebase.

@kovrus
Copy link
Member Author

kovrus commented Sep 28, 2022

ah.. @djaglowski dropped the whole range.

@bogdandrutu bogdandrutu merged commit dcce576 into open-telemetry:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants