Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Upgrade core dependency #14544

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[chore] Upgrade core dependency #14544

merged 1 commit into from
Sep 27, 2022

Conversation

dmitryax
Copy link
Member

Changes applied to adopt for open-telemetry/opentelemetry-collector#6099

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 27, 2022
codeboten
codeboten reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a change was missed:

Error: ./integration_test.go:264:32: pt.Int undefined (type pmetric.NumberDataPoint has no field or method Int)
Error: ./integration_test.go:266:32: pt.Int undefined (type pmetric.NumberDataPoint has no field or method Int)

@dmitryax dmitryax merged commit 93c7fc4 into open-telemetry:main Sep 27, 2022
@dmitryax dmitryax deleted the upgradcore branch November 15, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@punya punya Awaiting requested review from punya

@arminru arminru Awaiting requested review from arminru

Assignees

@mx-psi mx-psi

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmitryax @codeboten @bogdandrutu @mx-psi