[datadogexporter] Support resource conventions for hostnames #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
+ Coverage 87.43% 88.71% +1.28%
==========================================
Files 340 341 +1
Lines 16602 16702 +100
==========================================
+ Hits 14516 14818 +302
+ Misses 1631 1414 -217
- Partials 455 470 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5857e2e
to
44024db
Compare
|
cc @KSerrania and @ericmustin (for the traces code) to review |
ericmustin
approved these changes
Oct 31, 2020
bogdandrutu
approved these changes
Nov 1, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
…ice will do that (#1434) Signed-off-by: Bogdan Drutu <[email protected]>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Add a Config/Option for histogram * Just one option here * Test fixes * Support and test int64 histograms * Changelog * Lint * Un-export three things.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
#1434) Co-authored-by: Srikanth Chekuri <[email protected]> Co-authored-by: Diego Hurtado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The resource attributes of metrics and traces are now checked to see if there are any of
host.id,host.nameorcontainer.idto get a suitable hostname (see resource semantic conventions here). This hostname has preference over the one retrieved automatically. This allowsLink to tracking Issue: n/a
Testing: Added unit tests. Tested in an end to end environment
Documentation: Stated support for semantic conventions on the README. Documented public functions.