Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/mongodbatlas] Fix timestamp parsing for mongodb 4.2 audit logs #14173

Merged
merged 1 commit into from
Sep 16, 2022
Merged

[receiver/mongodbatlas] Fix timestamp parsing for mongodb 4.2 audit logs #14173

merged 1 commit into from
Sep 16, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

Description:

  • The timestamp format differed slightly between 4.2 and 4.4 clusters; This PR changes the timestamp format based on the cluster version, similar to the normal mongodb logs.

Link to tracking Issue: Resolves #14168

Testing:

  • Added unit test testing timestamp parsing for 4.2 formatted timestamps
  • Manually tested against a 4.2 cluster to ensure audit log timestamps parsed correctly

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review September 16, 2022 18:32
@BinaryFissionGames BinaryFissionGames requested a review from a team as a code owner September 16, 2022 18:32
@djaglowski djaglowski merged commit ac4e171 into open-telemetry:main Sep 16, 2022
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request Sep 19, 2022
@BinaryFissionGames @djaglowski
[receiver/mongodbatlas] Fix timestamp parsing for mongodb 4.2 audit l…
a61aa3c 
…ogs (open-telemetry#14173)

fix timestamp parsing for mongodb 4.2 audit logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@TylerHelmuth TylerHelmuth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/mongodbatlas] Audit log timestamp parsing fails to parse on 4.2 clusters
3 participants
@BinaryFissionGames @djaglowski @TylerHelmuth