[exporter/sumologic] Make the exporter to not mutate logs data #13923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exporter unnecessary mutates log data just to temporarily copy resource attributes into log attributes. This change removes that redundant step which make the exporter not mutating anymore.
bogdandrutu
approved these changes
Sep 7, 2022
bogdandrutu
reviewed
Sep 7, 2022
| }) | ||
| return true | ||
| }) | ||
| } | ||
| returnValue.Sort() |
There was a problem hiding this comment.
Should be done in a separate PR, owners should look into this.
There was a problem hiding this comment.
Yes, sort seems redundant. didn't want to do unrelated refactoring in this PR
| func (f *filter) filterIn(attributes pcommon.Map) fields { | ||
| // mergeAndFilterIn merges provided attribute maps and returns fields which match at least one of the filter regexes. | ||
| // Later attribute maps take precedence over former ones. | ||
| func (f *filter) mergeAndFilterIn(attrMaps ...pcommon.Map) fields { | ||
| returnValue := pcommon.NewMap() |
There was a problem hiding this comment.
Same, this can be done in a separate PR.
|
@sumo-drosiek PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter unnecessary mutates log data just to temporarily copy resource attributes into log attributes. This change removes that redundant step which make the exporter not mutating anymore.