[exporter/instana] Simplify pushConvertedTraces tests #13851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Sep 2, 2022
There are a lot of redundant code. `TestPushConvertedDefaultTraces` and `TestPushConvertedSimpleTraces` are equivalent except for that one passes a trace with attributes to `pushConvertedTraces`, another passes a trace with SpanID/TraceID. It doesn't seem there is a reason to make that distinction. This change combine the tests into one passing a trace with both attributes and SpanID/TraceID to `pushConvertedTraces`.
275c0d3
to
23110cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just removing some redundant code.
TestPushConvertedDefaultTracesandTestPushConvertedSimpleTracesare equivalent except for that one passes a trace with attributes topushConvertedTraces, another passes a trace with SpanID/TraceID. It doesn't seem there is a reason to make that distinction. This change combine the tests into one passing a trace with both attributes and SpanID/TraceID topushConvertedTraces.