[receiver/k8scluster] Move k8s clients creation to the starting phase #13772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
refactor-k8s-cluster-receiver
branch
2 times, most recently
from
c773c76
to
a27e5a6
Compare
This is mostly a refactoring PRs with no actual changes except for moving initialization of k8s client from receiver init to receiver start phase. This allows to move all the client creation logic and its mocks to the struct that is actually utilize them instead of keeping them in Config struct.
dmitryax
force-pushed
the
refactor-k8s-cluster-receiver
branch
from
a27e5a6
to
2b205b6
Compare
jpkrohling
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a refactoring PRs with no actual changes except for moving initialization of k8s client from receiver init to receiver start phase. This allows us to move all the k8s client creation logic and its mocks to the struct where they are actually being used them instead of keeping them in Config struct.