Update core dependency and remove usage of deprecated APIs #13703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
a team,
djaglowski,
dashpole,
jmacd,
Aneurysm9,
jpkrohling,
mx-psi,
TylerHelmuth,
bogdandrutu,
jsuereth,
punya and
arminru
as code owners
dmitryax
force-pushed
the
replace-upsert-usages
branch
from
99b1e16
to
aee094f
Compare
bogdandrutu
approved these changes
Aug 29, 2022
| @@ -345,7 +345,7 @@ func getSummaryMetric(name string, attributes pcommon.Map, ts uint64, sum float6 | |||
| dp.SetCount(count) | |||
| dp.SetSum(sum) | |||
| attributes.Range(func(k string, v pcommon.Value) bool { | |||
There was a problem hiding this comment.
attributes.CopyTo(dp.Attributes())? Can be a separate PR.
Comment on lines
+371
to
+373
| subMap.InsertBool("UIx", false) | ||
| subMap.InsertBool("UI4", true) | ||
| subMap.InsertBool("flow-alt3", false) |
There was a problem hiding this comment.
s/InsertBool/UpsertBool
Can be a separate PR.
Comment on lines
38
to
+39
| SetValue(value, val) | ||
| attrs.Upsert(mapKey, value) | ||
| value.CopyTo(attrs.UpsertEmpty(mapKey)) |
There was a problem hiding this comment.
SetValue(attrs.UpsertEmpty(mapKey), val)
Should be a separate PR.
There was a problem hiding this comment.
Yeah I wanted to keep this PR's scope limited and apply other improvements after
dmitryax
force-pushed
the
replace-upsert-usages
branch
from
aee094f
to
e01002a
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
replace-upsert-usages
branch
2 times, most recently
from
3cbda4a
to
5cf7db4
Compare
Replace usages of - Map.Upsert - pcommon.InvalidTraceID - pcommon.InvalidSpanID
dmitryax
force-pushed
the
replace-upsert-usages
branch
from
5cf7db4
to
88fdcbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usages of: