-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the jaeger thrift http exporter from core to contrib repo #137
Conversation
The testbed is currently failing due to the duplicate exporter for |
@objectiser just to be 100% sure: no actual code changes just taking the files as they are. Regarding the error, we can rename it temporarily so we can do the merges on the repos independently, but before we release and tag another contrib we go back to |
@pjanotti Yes that is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually LGTM @objectiser, just setting as "request changes" so we can coordinate correctly.
@objectiser could you please push a change with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you please rebase @objectiser
4cd5cff
to
17d7833
Compare
17d7833
to
6f9a5c9
Compare
287b91b
to
426f85d
Compare
… with exporter still being found in core
426f85d
to
6afda59
Compare
* Fix compilation with Golang 1.13 * run go mod tidy again
Description:
This PR is to enact action item 3 from open-telemetry/opentelemetry-collector#618 (comment). Not sure if possible to preserve history, but this code was copied from here.
Link to tracking Issue:
Related to open-telemetry/opentelemetry-collector#618
Testing:
Uses existing tests copied from core repo.
Documentation:
Text from exporter README (jaeger thrift http section) has been extracted and added to a new README in the exporter's folder.