[receiver/aerospikereceiver] Add query metrics. #13295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt lifecycle test skip
…telemetry-collector-contrib into aerospikereceiver-perf
djaglowski
reviewed
Aug 13, 2022
| "timeUnixNano": "1660328843530626000" | ||
| }, | ||
| { | ||
| "asInt": "0", |
There was a problem hiding this comment.
It looks like the integration test environment produced 0 for basically all the new metrics. Do you think it's worth updating the scraper test to cover at least some of them, to ensure a given response results in non-zero data points?
There was a problem hiding this comment.
yes I agree. In order to populate those metrics I'll have to set something up that makes requests to the test container. I can make an issue ticket for that and make it my next PR.
Co-authored-by: Daniel Jaglowski <[email protected]>
…r-contrib into aerospikereceiver-metrics
djaglowski
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add query_count and query_json metrics. Useful for tracking query transactions.
Link to tracking Issue: 13255
Testing: Integration test adjusted for new metrics. Unit tests passed. local testing with Aerospike cluster.
Documentation: Automated changes made to documentation.md by mdatagen reflecting new metrics.