[receiver/syslog] Migrate config unmarshaling from yaml to mapstructure #13253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/stanza historically used yaml for configuration unmarshaling. The process of migrating to mapstructure was begun long ago but was never completed. This PR switches syslog's underlying operators to use mapstructure unmarshaling.
djaglowski
force-pushed
the
pkg-stanza-syslog-mapstructure
branch
from
91c49bd
to
2d99715
Compare
bogdandrutu
reviewed
Aug 12, 2022
| @@ -59,8 +59,8 @@ func NewConfig(operatorID string) *Config { | |||
|
|
|||
| // Config is the configuration of a tcp input operator. | |||
| type Config struct { | |||
| helper.InputConfig `yaml:",inline"` | |||
| BaseConfig `yaml:",inline"` | |||
| helper.InputConfig `mapstructure:",squash" yaml:",inline"` | |||
There was a problem hiding this comment.
Do you want to maintain yaml and json tags as well?
There was a problem hiding this comment.
For now, but I would like to remove them as a separate effort. There will be a bunch of related code that can be pulled out too, so I think a separate PR will make sense.
There was a problem hiding this comment.
sure, just checking the long term commitment that we make here.
bogdandrutu
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/stanza historically used yaml for configuration unmarshaling.
The process of migrating to mapstructure was begun long ago but
was never completed. This PR switches syslog's underlying operators
to use mapstructure unmarshaling.