Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Makefile] Fix docker-otelcontribcol make target #13159

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Aug 10, 2022

This change reverts #12217 that broke docker-otelcontribcol make target as an incorrect attempt to create multi arch docker images.

This change also removes the changelog entry line for #12217 since it's not a user facing change.

@dmitryax dmitryax requested a review from a team as a code owner August 10, 2022 04:07
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 10, 2022
@dmitryax dmitryax force-pushed the fix-make-docker-otelcontribcol branch from 5ad3e9d to 5e5dc8d Compare August 10, 2022 04:12
@jpkrohling
Copy link
Member

cc @gyliu513

@jpkrohling jpkrohling merged commit ae3ce29 into open-telemetry:main Aug 10, 2022
@gyliu513
Copy link
Contributor

@dmitryax I do have a questions here: How can I run this on non linux amd64 platforms?

@dmitryax
Copy link
Member Author

@gyliu513 you cannot at this point. If you want, please submit a PR that produces a multi-arch docker image from make docker-otelcontribcol or make it produce an image for host arch but don't change $GOOS.

@gyliu513
Copy link
Contributor

@dmitryax what is the difference from make docker-component and make docker-otelcontribcol, I can see make docker-otelcontribcol is the only one who is calling make docker-component, am I missing anything? Thanks!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants